Differential D27515

Icon: fix rendering of image: urls on High DPI
ClosedPublic
Actions

Authored by apol on Feb 20 2020, 2:20 AM.

Details

Reviewers
mart
davidedmundson
Group Reviewers
Plasma
Kirigami
Commits
R169:2c4cc4816c04: Icon: fix rendering of image: urls on High DPI
Summary

QQuickImageProvider wants the requestedSize to be accounting for the dpi
scaling. We have no information about about the DPI from the implementation
anyway.
This is also how it's explained in the qtdeclarative/manual/highdpi/ test in Qt.

BUG: 417647

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Feb 20 2020, 2:20 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptFeb 20 2020, 2:20 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Feb 20 2020, 2:20 AM
davidedmundson added a subscriber: davidedmundson.Feb 20 2020, 11:06 AM

QQuickImageProvider wants the requestedSize to be accounting for the dpi scaling.

For stupid reasons, that isn't the case if the path is an SVG.

davidedmundson accepted this revision.Feb 20 2020, 2:50 PM

I was wrong.

QQuickImageBase is the part that has the SVG check.

This is going directly one level lower

This revision is now accepted and ready to land.Feb 20 2020, 2:50 PM
Closed by commit R169:2c4cc4816c04: Icon: fix rendering of image: urls on High DPI (authored by apol). · Explain WhyFeb 20 2020, 2:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/icon.cpp (5 lines)

Diff 76052

View Options

src/icon.cpp

Loading...