| dfaure | |
| meven | |
| sitter | |
| broulik |
| Frameworks |
When setting the mime filter, check that the QMimeType we get from
QMimeDatabase::mimeTypeForName() is valid before adding it to the mime
filter list. This fixes a bug where if the QMimeType is invalid its name
(and comment) property is empty, leading to empty entries in the filter
widget drop-down menu.
Per dfaure's recommendation, display a warning about the invalid mimeType.
Also install the necessary Qt logging catergory bits for KFileWidgets.
BUG: 417355
FIXED-IN: 5.68
| No Linters Available |
| No Unit Test Coverage |
| Buildable 23318 | |
| Build 23336: arc lint + arc unit |
Maybe add a warning about the invalid type? After all it's a programmer error to send us invalid mimetypes here, right? Are you also fixing the source of the issue in gwenview?
Thanks!
A warning makes sense, yes.
About gwenview, it's on my todo list to track down the issue there next.
@kossebau: did I get the Qt logging bits correctly? (I copied from your other related commits :)).
Looks good from a quick scan. If the content of the generated kio.categories files also matches what you expect, things are fine. Perhaps I would invert things and generate the header for kf5.kio.filewidgets.kfilefiltercombo and include that, instead of the manual definition in the C++ code. And do the ecm_qt_export_logging_category for kf5.kio.filewidgets instead, given this is not yet used.
Meh, I really need to get to finish my prototype for T12741, which also brings the ability to define multiple categories per generated header, instead of just one. That should get more sanity into things.
| src/filewidgets/kfilefiltercombo.cpp | ||
|---|---|---|
| 32 | Err why don't you include kiofilewidgets_debug.h instead? You're redefining what the generated file contains, here. | |
| src/filewidgets/kfilefiltercombo.cpp | ||
|---|---|---|
| 32 | No, the generated one contains only kf5.kio.filewidgets, not kf5.kio.filewidgets.kfilefiltercombo. | |
| src/filewidgets/kfilefiltercombo.cpp | ||
|---|---|---|
| 157 ↗ | (On Diff #77029) | IMHO it's a programmer error so it should be a qCWarning (visible by default), not a qCDebug (invisible by default). |
Rebase. Per dfaure's recommendation use qCWarning instead of qCDebug, the former is visible by default, which makes sense for a programmer error (feeding the open file dialog invalid mimeTypes).