| cblack | |
| niccolove | |
| apol |
| VDG | |
| Plasma |
As discussed in T12778, the icon can never be in a correct state: either it's
redundant with the icon you're hovering over that made the tooltip appear, or
else it's different from the icon you're hovering over, which is inconsistent.
Since either case is undesirable, let's just remove the icon from the tooltip
entirely. This reduces the visual noise in the tooltip and solves the entire
class of bugs automatically.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
If the Plasma people accept, this would need to wait until Frameworks 5.70 to land or else rolling release distros will lose icons in half their tooltips, but not the rest.
I think this was done at the wrong level. If we don't want icons in the systray then the way would be to net set the property in the systray and not ignore the property in the generic component but keep the property for api stability purposes. Now we have a component with a documented property that doesn't work. People trying to use this will think it's broken while we can't use it in any context where we want an icon in the future. Furthermore it's inconsistent that one can still set an icon via image strengthening the broken look from the outside.
See the parent task.
This component doesn't only darw system tray tooltips but rather tooltips for all panel widgets. The idea was that we don't want icons in *any* of these tooltips, because they're either redundant or inconsistent with the icon that you're hovering the mouse over. For this patch, I guess I should have marked the icon parameter as deprecated. I can do that in a follow-up patch.
I didn't remove the display of a custom image because I figured that in this case, the designer was specifically trying to set something different. But maybe that should be deprecated too. Open to opinions.
On another note, it would have been nice if these concerns had been brought up during the month when the patch was open for review.
For all panel widgets
which are all governed by a single place: plasma-desktop/desktoppackage/contents/applet/CompactApplet.qml
Imho an unacceptable behavior break for a Frameworks component.
Wouldn't then be the solution to remove icons to wherever the panel widgets set them? And why would a designer only explicitely set images but not icons? Also this component does not only draw panel tooltips but also other tooltips, for example on the widget edit handle things.
Sorry for not noticing earlier
Fixed in 7aaee715aff2a3fadf950f686a8be5e0d49c3297 and did it the correct way in 1f0cf38dbf2eb7de2b7fe09ef82bbb281a296a68. Sorry about the breakage.