Differential D27833

Add an accessor to get the last loaded value for KConfigSkeletonItem
AbandonedPublic
Actions

Authored by meven on Mar 4 2020, 1:45 PM.

Details

Reviewers
ervin
bport
crossi
Group Reviewers
Frameworks
Summary

It allows to know the last load values from KConfig, for some edge case where is is needed to be accessed directly.

Test Plan

build && ctest

Diff Detail

Repository
R237 KConfig
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23252
Build 23270: arc lint + arc unit
meven created this revision.Mar 4 2020, 1:45 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 4 2020, 1:45 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Mar 4 2020, 1:45 PM
meven updated this revision to Diff 76937.Mar 4 2020, 1:47 PM

Avoid some space changes

meven updated this revision to Diff 76938.Mar 4 2020, 1:48 PM

Clean qDebug traces

meven retitled this revision from Add an accessor to get the last load value for KConfigSkeletonItem to Add an accessor to get the last loaded value for KConfigSkeletonItem.Mar 4 2020, 1:49 PM
apol added a subscriber: apol.Mar 5 2020, 12:42 AM

What's the use-case?

ervin requested changes to this revision.Mar 5 2020, 3:45 PM
In D27833#622353, @apol wrote:

What's the use-case?

Having an idea of the patch you want to build on top of this would indeed help.

src/core/kcoreconfigskeleton.cpp
210 ↗(On Diff #76936)

Missing space before =

226 ↗(On Diff #76936)

This is already a QVariant

This revision now requires changes to proceed.Mar 5 2020, 3:45 PM
meven added a comment.Mar 8 2020, 6:12 PM
In D27833#622353, @apol wrote:

What's the use-case?

Originally D27934 was needing it, but in the end this is not needed anymore, so I think it should be best to postpone this change for KF6, avoiding to introduces those BC shenanigans.

meven abandoned this revision.Mar 16 2020, 1:47 PM

This is not needed anymore.

Showing Only Differences

This revision modifies 3 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
Msrc/core/kcoreconfigskeleton.cpp (19 lines)

Diff 76937

View Options

src/core/kcoreconfigskeleton.cpp

Loading...