Add an accessor to get the last loaded value for KConfigSkeletonItem
AbandonedPublic
Actions

Authored by meven on Mar 4 2020, 1:45 PM.

Details

Reviewers

ervin
bport
crossi

Group Reviewers

Frameworks

Summary

It allows to know the last load values from KConfig, for some edge case where is is needed to be accessed directly.

Test Plan

build && ctest

Diff Detail

Repository

R237 KConfig

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 23253
Build 23271: arc lint + arc unit

meven created this revision.Mar 4 2020, 1:45 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptMar 4 2020, 1:45 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

meven requested review of this revision.Mar 4 2020, 1:45 PM

Harbormaster completed remote builds in B23251: Diff 76936.Mar 4 2020, 1:45 PM

Inspired by 4c3d3751968422ff5cba56b5da2036a1bceba314

Avoid some space changes

Harbormaster completed remote builds in B23252: Diff 76937.Mar 4 2020, 1:47 PM

Clean qDebug traces

Harbormaster completed remote builds in B23253: Diff 76938.Mar 4 2020, 1:48 PM

meven retitled this revision from Add an accessor to get the last load value for KConfigSkeletonItem to Add an accessor to get the last loaded value for KConfigSkeletonItem.Mar 4 2020, 1:49 PM

What's the use-case?

In D27833#622353, @apol wrote:

What's the use-case?

Having an idea of the patch you want to build on top of this would indeed help.

src/core/kcoreconfigskeleton.cpp
210	Missing space before =
226	This is already a QVariant

This revision now requires changes to proceed.Mar 5 2020, 3:45 PM

In D27833#622353, @apol wrote:

What's the use-case?

Originally D27934 was needing it, but in the end this is not needed anymore, so I think it should be best to postpone this change for KF6, avoiding to introduces those BC shenanigans.

This is not needed anymore.

Revision Contents
Changeset List

			Path	Packages
M			autotests/kconfigloadertest.cpp (19 lines)
M			src/core/kcoreconfigskeleton.h (9 lines)
M			src/core/kcoreconfigskeleton.cpp (17 lines)
M			src/core/kcoreconfigskeleton_p.h (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	76936	abe6188		Mar 4 2020, 1:45 PM	★	★
Diff 2	76937	abe6188	Avoid some space changes	Mar 4 2020, 1:47 PM	★	★
Diff 3	76938	abe6188	Clean qDebug traces	Mar 4 2020, 1:48 PM	★	★