Differential D27513

Kill Runner: Remove duplicate function calls and refactor
ClosedPublic
Actions

Authored by alex on Feb 19 2020, 7:58 PM.

Details

Reviewers
davidedmundson
ngraham
broulik
meven
apol
Commits
R120:6f103ebd7b3a: Kill Runner: Remove duplicate function calls and refactor
Summary

Duplicate function calls to load the config in the runner/config have been removed.
The actions of the runner are also refactored, similar to https://phabricator.kde.org/D3688.
Also the user (owner of process) has been removed from the subtext, because the second line is not shown and adding the user info to the same line would be too long.

Test Plan

Should compile and kill processes as before.

Diff Detail

Repository
R120 Plasma Workspace
Branch
killrunner_cleanup (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22781
Build 22799: arc lint + arc unit
alex created this revision.Feb 19 2020, 7:58 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 19 2020, 7:58 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
alex requested review of this revision.Feb 19 2020, 7:58 PM
alex updated this revision to Diff 76023.Feb 19 2020, 8:07 PM

Remove QDebug include, add license

apol added a subscriber: apol.Feb 20 2020, 2:31 PM

Seems to me like there's 2 very different changes here, can you split in 2 reviews?

runners/kill/CMakeLists.txt
19–20

just pass it to add_library

alex updated this revision to Diff 76085.Feb 21 2020, 9:55 AM

Pass file directly to add_library

alex updated this revision to Diff 76149.Feb 22 2020, 9:58 AM
alex marked an inline comment as done.

Revert moving of config keys from commit "Remove duplicate function calls, move config keys to new file"

alex edited the summary of this revision. (Show Details)Feb 22 2020, 10:39 AM
alex added a reviewer: apol.
alex added a comment.Mar 25 2020, 7:32 AM

Friendly Ping :-)

alex updated this revision to Diff 81006.Apr 23 2020, 3:02 PM

Fix small issue from splitting up patch

alex updated this revision to Diff 82666.May 12 2020, 3:16 PM

Rebase

alex updated this revision to Diff 82669.May 12 2020, 3:26 PM

Formatting

meven accepted this revision.May 13 2020, 8:01 AM
This revision is now accepted and ready to land.May 13 2020, 8:01 AM
Closed by commit R120:6f103ebd7b3a: Kill Runner: Remove duplicate function calls and refactor (authored by alex). · Explain WhyMay 13 2020, 8:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 76149

View Options

runners/kill/CMakeLists.txt

Loading...
View Options

runners/kill/killrunner.h

Loading...
View Options

runners/kill/killrunner.cpp

Loading...
View Options

runners/kill/killrunner_config.h

Loading...
View Options

runners/kill/killrunner_config.cpp

Loading...