- When GenerateProperties and Mutators are activated, the generated code did not handle min/max properly
- In the case of a parameterized entry, generated code also did not handle min/max
BUG: 418146
Details
Details
- auto tests included
Diff Detail
Diff Detail
- Repository
- R237 KConfig
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| autotests/kconfig_compiler/test_param_minmax.kcfg | ||
|---|---|---|
| 18 | Add a new line | |
| autotests/kconfig_compiler/test_param_minmax.kcfgc | ||
| 5 | add a new line | |
| autotests/kconfig_compiler/test_param_minmax_main.cpp | ||
| 29 | Missing new line at end of this file | |
| src/kconfig_compiler/KConfigCommonStructs.h | ||
| 192 | Space before * not after | |
| src/kconfig_compiler/kconfig_compiler.cpp | ||
| 484 | Space before * not after | |
Comment Actions
Seems good to me
| autotests/kconfig_compiler/test_param_minmax.h.ref | ||
|---|---|---|
| 26 | We probably should not output anything or at least let the user give logging context to the debug output. | |
Comment Actions
A few smallish issues only, otherwise LGTM.
| src/kconfig_compiler/KConfigSourceGenerator.cpp | ||
|---|---|---|
| 316–322 | I'd const it and also use the = style of initialization which I find more readable. | |
| 354 | const those please | |
| 372 | ditto | |
| src/kconfig_compiler/kconfig_compiler.cpp | ||
| 397–406 | const | |
| 401 | const | |
| 462 | Should be named newInnerItem | |
| autotests/kconfig_compiler/test_properties_minmax.h.ref | ||
|---|---|---|
| 43 | This is incorrrect since D27496, too bad this was not rebased and tested before before landing WARNING: KConfigCompiler_Test::testRunning(test_properties_minmax) testdata test_properties_minmax could not be located! Loc: [/repositories/src/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp(155)] FAIL! : KConfigCompiler_Test::testRunning(test_properties_minmax) '!program.isEmpty()' returned FALSE. (test_properties_minmax must exist!) Loc: [/repositories/src/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp(156)] WARNING: KConfigCompiler_Test::testRunning(test_param_minmax) testdata test_param_minmax could not be located! Loc: [/repositories/src/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp(155)] FAIL! : KConfigCompiler_Test::testRunning(test_param_minmax) '!program.isEmpty()' returned FALSE. (test_param_minmax must exist!) Loc: [/repositories/src/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp(156)] FAIL! : KConfigCompiler_Test::testBaselineComparison(test_properties_minmax.h) 'false' returned FALSE. (This test failed, look at the following file for details: /repositories/src/kconfig/autotests/kconfig_compiler/test_properties_minmax.h.ref.diff) Loc: [/repositories/src/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp(190)] FAIL! : KConfigCompiler_Test::testBaselineComparison(test_properties_minmax.h) 'content == contentRef' returned FALSE. () Loc: [/repositories/src/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp(135)] | |