This revision:
- adds the option to set an accent colour
- allows the colour scheme editor to ignore an active accent colour
Some notes:
- This works odd to say the least. Seems like there's some form of caching of the colour scheme going on?
Plasma | |
VDG |
This revision:
Some notes:
No Linters Available |
No Unit Test Coverage |
Buildable 24864 | |
Build 24882: arc lint + arc unit |
Since this is related, I'll just drop my concept design for Colours KCM for reference on a possible colour schemes header design to consider. Ignore the button at the bottom, I've realised now that that idea is pointless since we removed so many colour schemes by now out of the box that having a separate page for all the colour schemes is no longer a pointful idea.
Technical Explanation, again:
Oh, and also maybe put the checkbox you've implemented below that 'Custom Accent Colour...' button if you do implement this design - checking it'll insensitive the button and the accent colour circles.
This doesn't compile for me:
/home/nate/kde/src/plasma-desktop/kcms/colors/editor/scmeditorcolors.cpp: In member function ‘void SchemeEditorColors::updateColorSchemes()’: /home/nate/kde/src/plasma-desktop/kcms/colors/editor/scmeditorcolors.cpp:378:16: error: ‘class KColorScheme’ has no member named ‘dropAccentColors’ 378 | scheme.dropAccentColors(); | ^~~~~~~~~~~~~~~~
Also in terms of the UI, I might recommend using radio buttons, sort of like this:
Accent color: (o) Let the active color scheme choose ( ) Custom color: [ color chooser button ]
This makes the two states clearer IMO. Also it might be good to put whatever UI we use below the color scheme chooser grid, since the accent color is a subordinate setting.
You need the patch this patch depends on, D27263.
Also in terms of the UI, I might recommend using radio buttons, sort of like this:
Accent color: (o) Let the active color scheme choose ( ) Custom color: [ color chooser button ]This makes the two states clearer IMO. Also it might be good to put whatever UI we use below the color scheme chooser grid, since the accent color is a subordinate setting.
👍
Whoops, my bad.
Tested this and found that setting an accept color seems to work for apps and Plasma (yay), but unsetting it doesn't go back to the color-scheme-provided one.
These new properties can be managed by KConfig.
It will automatically handle the read/write process and isSaveNeeded/isDefault status.
Could you move this and the dependent patches to Gitlab? It would be good to get this in for 5.21.