[applets/taskmanager] Clean up Tooltip code

Authored by ngraham on Feb 6 2020, 5:00 AM.

Description

[applets/taskmanager] Clean up Tooltip code

Summary:
The ToolTip code was kind of messy. This patch adjusts it to use modern Layouts,
fixes some binding loops, reduces redundancy, adds comments, removes a lot of
unnecessary code, and ports almost everything to PlasmaComponents3. We still
need PC2 for Highlight so it can't be removed entirely.

There is only one unavoidable visual change, which was made in this patch
because it is consistent with the latest VDG mockup (T12640): the blurred
album art background no longer goes under the player controls bar. This
simplifies the code substantially, and as the mockup shows, it just looks better
anyway (IMO).

This is not intended to fully implement the mockup in T12640.

Test Plan:
Everything looks the same, except for this:

Reviewers: Plasma, VDG, ndavis

Reviewed By: VDG, ndavis

Subscribers: hein, trmdi, broulik, plasma-devel

Tags: Plasma

Maniphest Tasks: T12640

Differential Revision: https://phabricator.kde.org/D27182

Details

Committed
ngrahamFeb 7 2020, 6:10 PM
Reviewer
VDG
Differential Revision
D27182: [applets/taskmanager] Clean up Tooltip code
Parents
R119:640ee27df289: Merge branch 'Plasma/5.18'
Branches
Unknown
Tags
Unknown

Why preview is so pixely? Why not to make smooth preview by Default?

That's unrelated to this patch, but to answer your question, it's a graphics driver related bug: https://bugs.kde.org/show_bug.cgi?id=360457

gvgeo added a subscriber: gvgeo.EditedFeb 20 2020, 9:40 PM

Logged with my main user, and panel does not respond
file:///code/kde/usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/ToolTipInstance.qml:115:13: QML Heading: Binding loop detected for property "width"
Without fillWidth in headings, works but with massive bind loops.

Logged with my main user, and panel does not respond

file:///code/kde/usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/ToolTipInstance.qml:115:13: QML Heading: Binding loop detected for property "width"

Without fillWidth in headings, works but with massive bind loops.

Hmm, I don't see that with everything from git master. :/

gvgeo added a comment.Feb 21 2020, 3:33 PM

Hmm, I don't see that with everything from git master. :/

Wrong alarm, works fine after updating everything. I didn't expect couple days to cause this, sorry.