RFC: Accent colour for KColorScheme
Needs ReviewPublic

Authored by cblack on Sun, Feb 9, 7:08 AM.

Details

Summary

This is a roughly thrown-together patch demonstrating how an
accent colour can be implemented via modifiying KColorScheme.

Stuff I plan to do:

  • Figure out a way to more elegantly handle inactive and disabled accent colours
Test Plan

Add Foreground and Background colors to [Accent] in kdeglobals

Diff Detail

Repository
R265 KConfigWidgets
Branch
kcolorscheme-accent (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22273
Build 22291: arc lint + arc unit
cblack created this revision.Sun, Feb 9, 7:08 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSun, Feb 9, 7:08 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
cblack requested review of this revision.Sun, Feb 9, 7:08 AM
cblack edited the summary of this revision. (Show Details)Sun, Feb 9, 7:12 AM
ndavis added a comment.Sun, Feb 9, 8:40 AM

I know this isn't the final version, but I'm not a fan of this idea. It feels like we'd just piling new stuff on top without properly using the old stuff that is already usable. I think if we're not careful, it'll just make color customization more confusing and difficult to work with by causing unexpected behavior where the old and new systems collide and one overrides the other.

Do we really need to create a color setting for accent that is separate from QPalette::Highlight/Selection Background? If you really want accent colors, I'd say deprecate FocusColor and HoverColor. As a fallback, have focus and hover state colors be based on QPalette::Highlight/Selection Background and set QPalette::Highlight directly instead of defining a separate accent color.

cblack updated this revision to Diff 75310.Sun, Feb 9, 7:07 PM

Load accent colour from kdeglobals instead of colourscheme

cblack edited the summary of this revision. (Show Details)Sun, Feb 9, 7:08 PM
cblack edited the test plan for this revision. (Show Details)
cblack updated this revision to Diff 75311.Sun, Feb 9, 7:35 PM

Expose method to drop accent colours from a KColorScheme object

cblack edited the summary of this revision. (Show Details)Sun, Feb 9, 7:36 PM

Looks like plasma doesn't respect the accent color.