Differential D2727

don't list "NoDisplay" panels
ClosedPublic
Actions

Authored by mart on Sep 9 2016, 1:15 PM.

Details

Reviewers
bshah
Group Reviewers
Plasma
Commits
R871:fa128c722d50: don't list "NoDisplay" panels
R120:fa128c722d50: don't list "NoDisplay" panels
Summary

some panel plugins don't want to be displayed in the context menu
with the NoDisplay key.
for instance, the systray

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart updated this revision to Diff 6598.Sep 9 2016, 1:15 PM
mart retitled this revision from to don't list "NoDisplay" panels.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
Restricted Application added a project: Plasma. · View Herald TranscriptSep 9 2016, 1:15 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added a reviewer: Plasma.Sep 9 2016, 1:15 PM
bshah accepted this revision.Sep 9 2016, 1:16 PM
bshah added a reviewer: bshah.
This revision is now accepted and ready to land.Sep 9 2016, 1:16 PM
Closed by commit R120:fa128c722d50: don't list "NoDisplay" panels (authored by mart). · Explain WhySep 9 2016, 1:17 PM
This revision was automatically updated to reflect the committed changes.
davidedmundson added a subscriber: davidedmundson.Sep 9 2016, 1:19 PM
davidedmundson added inline comments.
shell/shellcorona.cpp
1606

!= QLatin1String()

and below.

broulik added a subscriber: broulik.Sep 11 2016, 8:33 PM

Now it no longer lists the "Empty Panel" as it is marked as "NoDisplay".

broulik added a comment.Sep 11 2016, 8:43 PM

And there's some other madness going on, even with NoDisplay it is not shown as it:

  • is not a LayoutTempate (so it is not caught by the filter lambda)
  • it doesnt have X-Plasma-ContainmentType set (so it's not added by the other kservice query)

What's the deal with ContainmentType vs ContainmentCategories anyway...

mart added a comment.Sep 12 2016, 7:55 AM
In D2727#50987, @broulik wrote:

And there's some other madness going on, even with NoDisplay it is not shown as it:

  • is not a LayoutTempate (so it is not caught by the filter lambda)
  • it doesnt have X-Plasma-ContainmentType set (so it's not added by the other kservice query)

    What's the deal with ContainmentType vs ContainmentCategories anyway...

hmm, ContainmentType should is set, i see two desktop files in the sources therefore a potential mess...

needs a way to be solved tough, as nodisplay entries should really not be listed,
tough the empty panel should not be listed in widget explorer, but listed there, sooo, hmm i don't know :/

mart added a comment.Sep 12 2016, 7:56 AM

i may revert this, tough the systray containment really needs to *not* be listed in that menu

Revision Contents
Changeset List

PathPackages
Mshell/shellcorona.cpp (7 lines)

Diff 6599

View Options

shell/shellcorona.cpp

Loading...