Differential D2747

Don't list raw containments in panels menu
ClosedPublic
Actions

Authored by davidedmundson on Sep 12 2016, 9:08 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R871:db3c2b98a67c: Don't list raw containments in panels menu
R120:db3c2b98a67c: Don't list raw containments in panels menu
Summary

Empty panel is now shipped as a LayoutTempate rendering this code
redundant.

Test Plan

Still have both default and empty panels listed

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 6637.Sep 12 2016, 9:08 AM
davidedmundson retitled this revision from to Don't list raw containments in panels menu.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 12 2016, 9:08 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Sep 12 2016, 9:09 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Sep 12 2016, 9:09 AM
Closed by commit R120:db3c2b98a67c: Don't list raw containments in panels menu (authored by davidedmundson). · Explain WhySep 12 2016, 9:28 AM
This revision was automatically updated to reflect the committed changes.
mart reopened this revision.Sep 19 2016, 9:55 PM

I think this should be reexamined.
I was just asked why a 3rd party dock looking panel is not listed here.
simple panels (potentially coming from ghns now) should be listed.

This revision is now accepted and ready to land.Sep 19 2016, 9:55 PM

Revision Contents
Changeset List

PathPackages
Mshell/shellcorona.cpp (7 lines)

Diff 6642

View Options

shell/shellcorona.cpp

Loading...