Add HEIF thumbnailer
AbandonedPublic

Authored by zzag on Feb 1 2020, 3:27 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Test Plan

Diff Detail

Repository
R320 KIO Extras
Branch
heic-thumbnailer
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21946
Build 21964: arc lint + arc unit
zzag created this revision.Feb 1 2020, 3:27 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptFeb 1 2020, 3:27 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
zzag requested review of this revision.Feb 1 2020, 3:27 PM
zzag edited the test plan for this revision. (Show Details)Feb 1 2020, 3:28 PM
zzag updated this revision to Diff 74836.Feb 1 2020, 3:32 PM

missing copyright stuff in Findlibheif.cmake

ngraham added a subscriber: ngraham.EditedFeb 1 2020, 3:38 PM

Very cool. So QImage supports this file format now such that you could open the image in, say, Gwenview?

broulik added a subscriber: broulik.Feb 1 2020, 3:40 PM

-1 for making a dedicated thumbnailer.
There's a Qt heif image plug in in the works in Qt. If any, we should help there or at least get our own into kimageformats, so Gwenview and others can open such files properly.

zzag added a comment.Feb 1 2020, 3:41 PM

Very cool. So QImage supports this file format now such that you could open the image in, say, Gwenview?

No, as far as I know there is no QImageIOHandler for HEIF files. However, applications such as GIMP, Krita, and digiKam are able to open HEIF files.

zzag abandoned this revision.Feb 1 2020, 3:41 PM
zzag added a comment.EditedFeb 1 2020, 4:09 PM

There's a Qt heif image plug in in the works in Qt. If any, we should help there or at least get our own into kimageformats, so Gwenview and others can open such files properly.

I assume that you want to get the first image stored in a heif file and use it as the thumbnail. I'm not sure whether it's a good idea to completely ignore thumbnails that are associated with the primary image.

cfeck added a subscriber: cfeck.Feb 1 2020, 4:59 PM

Where can we see the status of the HEIF Qt loader? If it correctly implements scaled image loading, then a separate thumbnailer indeed makes not much sense. If, however, it always loads the full image, then scales it down, we got a case for a separate thumbnailer such as this one.