Add network-wireless-hotspot icon
ClosedPublic

Authored by ndavis on Jan 11 2020, 11:49 PM.

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cblack created this revision.Jan 11 2020, 11:49 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 11 2020, 11:49 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
cblack requested review of this revision.Jan 11 2020, 11:49 PM
cblack edited the test plan for this revision. (Show Details)Jan 11 2020, 11:50 PM

Hmm, at normal size, the 8, 16, and 22px versions look too busy to me.:

For the 16 and 22px versions, maybe reduce the number of waves and increase the spacing between them. And do we even need an 8px version?

ndavis added a subscriber: ndavis.Jan 12 2020, 10:45 AM

Hmm, at normal size, the 8, 16, and 22px versions look too busy to me.:

I kind of agree.

For the 16 and 22px versions, maybe reduce the number of waves and increase the spacing between them. And do we even need an 8px version?

We don't need an 8px version.

@cblack, if we did need an 8px version, you'd have to edit index.theme and define the 8px device icons folder.


One trick I learned from looking at the wifi icon is that you don't have to perfectly center the lines and the cut. If you offset them in a consistent way, you can get the spacing you want and the lines will still look fine.

Here are edited versions of the 16 and 22px icons with a couple variations each:

In the 16px version, I used a 14px outer circle, lowered it by 1px and cut it with a right triangle.

In the 22px version, I cut it the same way, but only to give the triangle bottom variant a bit more space. It's not needed if you use the antenna variant.


I think the radio waves around the 32px version should be 1px thick.

@ndavis do you want to take over this revision? You have a better sense of what this icon should be than I do.

ndavis commandeered this revision.Feb 7 2020, 10:59 PM
ndavis added a reviewer: cblack.

sure

ndavis updated this revision to Diff 77142.Mar 6 2020, 10:03 PM
  • Update style
ndavis edited the test plan for this revision. (Show Details)Mar 6 2020, 10:05 PM
ngraham accepted this revision.Mar 7 2020, 4:05 AM
This revision is now accepted and ready to land.Mar 7 2020, 4:05 AM
This revision was automatically updated to reflect the committed changes.