Differential D26500

Change project name to "KWin"
ClosedPublic
Actions

Authored by zzag on Jan 7 2020, 4:29 PM.

Details

Reviewers

meven

Group Reviewers

KWin

Commits

R108:03ae441e23ef: Change project name to "KWin"

Summary

It's not "KWIN" nor "kWin" nor "kWIN" nor "kwin"

Test Plan

Qt Creator displays "KWin" with correct capitalization.

Diff Detail

Repository

R108 KWin

Branch

change-project-name

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 20766
Build 20784: arc lint + arc unit

zzag created this revision.Jan 7 2020, 4:29 PM

Restricted Application added a project: KWin. · View Herald TranscriptJan 7 2020, 4:29 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Jan 7 2020, 4:29 PM

Harbormaster completed remote builds in B20761: Diff 73001.Jan 7 2020, 4:29 PM

Great !

This revision is now accepted and ready to land.Jan 7 2020, 4:46 PM

Did you make sure it's not used elsewhere? There's some variables generated by project()

kpiwowarski awarded a token.Jan 7 2020, 5:20 PM

In D26500#589794, @apol wrote:

Did you make sure it's not used elsewhere? There's some variables generated by project()

I had looked at our CMakeLists.txt files and some stuff from extra-cmake-modules and didn't see anything that can become broken after this change... Although it might be a good idea to fix "<PROJECT-NAME>_SOURCE_DIR"

Don't set <PROJECT-NAME>_SOURCE_DIR

Harbormaster completed remote builds in B20766: Diff 73008.Jan 7 2020, 5:42 PM

Closed by commit R108:03ae441e23ef: Change project name to "KWin" (authored by zzag). · Explain WhyJan 25 2020, 1:05 AM

This revision was automatically updated to reflect the committed changes.

Now of course the most correct pronunciation is "Kay win." :) "Quinn" would require it to be spelled "Kwin" :)

In D26500#600581, @ngraham wrote:

Now of course the most correct pronunciation is "Kay win." :) "Quinn" would require it to be spelled "Kwin" :)

Meh, I think we can we live with that. ;-)

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (3 lines)
M			autotests/CMakeLists.txt (2 lines)
M			autotests/tabbox/CMakeLists.txt (2 lines)
M			effects/CMakeLists.txt (2 lines)
M			kcmkwin/common/CMakeLists.txt (4 lines)
M			kcmkwin/kwincompositing/CMakeLists.txt (2 lines)
M			kcmkwin/kwinoptions/CMakeLists.txt (4 lines)
M			kcmkwin/kwinscreenedges/CMakeLists.txt (4 lines)
M			kcmkwin/kwintabbox/CMakeLists.txt (6 lines)
M			tests/CMakeLists.txt (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	73001	e728460		Jan 7 2020, 4:29 PM	★	★
Diff 2	73008	e728460	Don't set <PROJECT-NAME>_SOURCE_DIR	Jan 7 2020, 5:42 PM	★	★
Diff 3	74343	6cff907	R108:03ae441e23efecd94941c833c65e52501e764025	Jan 25 2020, 1:05 AM	★	★