Change project name to "KWin"
ClosedPublic

Authored by zzag on Jan 7 2020, 4:29 PM.

Details

Summary

It's not "KWIN" nor "kWin" nor "kWIN" nor "kwin"

Test Plan

Qt Creator displays "KWin" with correct capitalization.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jan 7 2020, 4:29 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 7 2020, 4:29 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jan 7 2020, 4:29 PM
meven accepted this revision.Jan 7 2020, 4:46 PM
meven added a subscriber: meven.

Great !

This revision is now accepted and ready to land.Jan 7 2020, 4:46 PM
apol added a subscriber: apol.Jan 7 2020, 5:03 PM

Did you make sure it's not used elsewhere? There's some variables generated by project()

zzag added a comment.Jan 7 2020, 5:29 PM
In D26500#589794, @apol wrote:

Did you make sure it's not used elsewhere? There's some variables generated by project()

I had looked at our CMakeLists.txt files and some stuff from extra-cmake-modules and didn't see anything that can become broken after this change... Although it might be a good idea to fix "<PROJECT-NAME>_SOURCE_DIR"

zzag updated this revision to Diff 73008.Jan 7 2020, 5:42 PM

Don't set <PROJECT-NAME>_SOURCE_DIR

This revision was automatically updated to reflect the committed changes.

Now of course the most correct pronunciation is "Kay win." :) "Quinn" would require it to be spelled "Kwin" :)

zzag added a comment.Jan 25 2020, 11:29 AM

Now of course the most correct pronunciation is "Kay win." :) "Quinn" would require it to be spelled "Kwin" :)

Meh, I think we can we live with that. ;-)