Change project name to "KWin"
AcceptedPublic

Authored by zzag on Tue, Jan 7, 4:29 PM.

Details

Reviewers
meven
Group Reviewers
KWin
Summary

It's not "KWIN" nor "kWin" nor "kWIN" nor "kwin"

Test Plan

Qt Creator displays "KWin" with correct capitalization.

Diff Detail

Repository
R108 KWin
Branch
change-project-name
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 20766
Build 20784: arc lint + arc unit
zzag created this revision.Tue, Jan 7, 4:29 PM
Restricted Application added a project: KWin. · View Herald TranscriptTue, Jan 7, 4:29 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Tue, Jan 7, 4:29 PM
meven accepted this revision.Tue, Jan 7, 4:46 PM
meven added a subscriber: meven.

Great !

This revision is now accepted and ready to land.Tue, Jan 7, 4:46 PM
apol added a subscriber: apol.Tue, Jan 7, 5:03 PM

Did you make sure it's not used elsewhere? There's some variables generated by project()

zzag added a comment.Tue, Jan 7, 5:29 PM
In D26500#589794, @apol wrote:

Did you make sure it's not used elsewhere? There's some variables generated by project()

I had looked at our CMakeLists.txt files and some stuff from extra-cmake-modules and didn't see anything that can become broken after this change... Although it might be a good idea to fix "<PROJECT-NAME>_SOURCE_DIR"

zzag updated this revision to Diff 73008.Tue, Jan 7, 5:42 PM

Don't set <PROJECT-NAME>_SOURCE_DIR