It would be helpful if you could update the description to mention why this change is being made and when benefit comes from not reading desktop files' comment fields.

Also, updating the Test Plan section with details of your testing would be nice. :)

Thanks!

What about the directory Comment "feature" a few lines below? It is equally as questionable and causes significant slowdowns when browsing folders on nfs mounts, cf. D13757

In D26331#586565, @broulik wrote:

What about the directory Comment "feature" a few lines below? It is equally as questionable and causes significant slowdowns when browsing folders on nfs mounts, cf. D13757

I thought, the !d->isSlow() would skip that part for (fsType == KFileSystemType::Nfs || fsType == KFileSystemType::Smb) as seen in kfileitem.cpp:763. So I would leave that here.

Also, I see a lot more use cases for showing the comment from .directory files.
I could imagine setting up a computer for an inexperienced user, and adding .directory files to document what some directories are about.

In D26331#586783, @count wrote:

I thought, the !d->isSlow() would skip that part for (fsType == KFileSystemType::Nfs || fsType == KFileSystemType::Smb) as seen in kfileitem.cpp:763. So I would leave that here.

The is slow check itself blocks...

I could imagine setting up a computer for an inexperienced user

Do you know anyone doing this? Oh if only we had some telemetry :)
I doubt naming a folder "Technobabble" and then adding a helpful comment "This is where your cat pictures go" is very useful to the inexperienced user

In D26331#586842, @broulik wrote:

I doubt naming a folder "Technobabble" and then adding a helpful comment "This is where your cat pictures go" is very useful to the inexperienced user

100% agree

I don't understand this line of argumentation. Are you saying that all documentation in the world is useless?

You're setting up a computer for a new employee, with a whole lot of folders. Having some room to document "inline" the purpose of some folders sounds useful, doesn't it? (even more so with the translation support, but even without). You do that in .directory files which are part of the checkout and it's even directly useful for the next employee :)

What's missing however is that there's no GUI for setting those, one has to know about the hidden .directory feature (right?).

On the other hand I see that the dolphin GUI has an editable "Comment" on the right side, unfortunately it doesn't show in the treeview even after enabling the "Comments" column (bug?). And that's local, so not reusable for another user.

Having been a sysadmin setting up computers for new users, let me tell you that there is a 0% chance that I would use this feature. I would (and did, and have) *by far* prefer to document anything slightly confusing using an internal company-wide knowledge-base or wiki. That way I could actually point users to the explanation accessible in a web browser in a page I could send people the link to, and I could refine the documentation myself over time effortlessly.

Besides, this feature has no UI to discover it, so I would wager that approximately 0 people are actually using it. Of course, yes, if there was any telemetry, this wouldn't have to be a guess. :)

OK, remove it. The other feature (kfilemetadata?) should be fixed though....

In D26331#587259, @dfaure wrote:

On the other hand I see that the dolphin GUI has an editable "Comment" on the right side, unfortunately it doesn't show in the treeview even after enabling the "Comments" column (bug?). And that's local, so not reusable for another user.

The comment uses extended attributes, so at least for nfs it should work over network, not sure about cifs.

For me, the comment is shown in the sidebar and in the column.

unfortunately it doesn't show in the treeview even after enabling the "Comments" column (bug?)

Works here.

Ok, I've played a little around, and imho we should remove the support for .directory file comments too:

Here you see, the type column is read from the comment field inside the .directory file

[Desktop Entry]
Name=Neue Menükategorie
Comment=Blabla from .directory file
Icon=passendes_Symbol
Type=Directory

And here is the independent comment metadata

Makes sense to me, following the same logic.

I think you lost the original diff with the latest update to this patch.

Thanks! @count, can you provide us with your full name and email address so we can land this patch with accurate authorship information?

In D26331#588073, @ngraham wrote:

Thanks! @count, can you provide us with your full name and email address so we can land this patch with accurate authorship information?

It's count negative
count(dot)negative(at)gmx(dot)de

In D26331#588152, @count wrote:

In D26331#588073, @ngraham wrote:

Thanks! @count, can you provide us with your full name and email address so we can land this patch with accurate authorship information?

It's count negative
count(dot)negative(at)gmx(dot)de

If "Count Negative" is a pseudonym, please first submit a patch to https://cgit.kde.org/kde-dev-scripts.git/ that grants permission to relicense your commits should it ever become necessary and we can't contact you because opf the pseudonym. See the other commits in that repo for examples of what to submit. Once you've submitted the patch, link to it here.

Thanks!