Recompiled, Run Unittests
Diff Detail
Diff Detail
- Repository
- R237 KConfig
- Branch
- nitpicksLiteralString
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 20098 Build 20116: arc lint + arc unit
| src/kconfig_compiler/kconfig_compiler.cpp | ||
|---|---|---|
| 619 | std::any_of ? | |
| src/kconfig_compiler/kconfig_compiler.cpp | ||
|---|---|---|
| 619 | Indeed, could be replaced by any_of since we're at it. | |
Comment Actions
Does it apply on top of your refactoring? Also the description looks wrong now.
| src/kconfig_compiler/kconfig_compiler.cpp | ||
|---|---|---|
| 625 | Nitpick: there shouldn't be a space after ! Also: use std::cbegin and std::cend (I think they're allowed nowadays) | |
Comment Actions
Getting rid of the inversion might be easier to read for simple humans (as me :) ):
const bool isAscii = std::all_of(std::begin(s), std::end(s), [](QChar a) { return a.unicode() <= 127; });Comment Actions
I'd remove the space after '!' and make the bool const, but I'm nitpicking, you can also push as is.
cbegin/cend wouldn't change anything on a const container.