Differential D26048

KCM Notification port to ManagedConfigModule
ClosedPublic
Actions

Authored by crossi on Dec 16 2019, 4:01 PM.

Details

Reviewers
ervin
bport
mart
davidedmundson
meven
Group Reviewers
Plasma
Commits
R119:5a1d74059c09: KCM Notification port to ManagedConfigModule
Summary

Require D26046 and D26047 At least, the properties of Notification tab in the KCM is handled properly.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
crossi created this revision.Dec 16 2019, 4:01 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 16 2019, 4:01 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
crossi requested review of this revision.Dec 16 2019, 4:01 PM
meven accepted this revision.Dec 16 2019, 4:23 PM
This revision is now accepted and ready to land.Dec 16 2019, 4:23 PM
meven resigned from this revision.Dec 16 2019, 4:57 PM

Another "primary" reviewer would be more adequat

This revision now requires review to proceed.Dec 16 2019, 4:57 PM
davidedmundson accepted this revision.Dec 16 2019, 7:30 PM
This revision is now accepted and ready to land.Dec 16 2019, 7:30 PM
ervin accepted this revision.Dec 23 2019, 12:26 PM
crossi updated this revision to Diff 74028.Jan 21 2020, 5:00 PM

Following new approach in D26047, also taking into immutability is much more straightforward.

crossi requested review of this revision.Jan 21 2020, 5:02 PM
ervin requested changes to this revision.Jan 21 2020, 5:04 PM

Wondering, do we still need "settings"? I guess it's for the per-app settings?

kcms/notifications/kcm.cpp
115

Not necessary anymore

This revision now requires changes to proceed.Jan 21 2020, 5:04 PM
crossi added a comment.Jan 21 2020, 5:57 PM
In D26048#598157, @ervin wrote:

Wondering, do we still need "settings"? I guess it's for the per-app settings?

Yes, for app specific settings.

crossi updated this revision to Diff 74037.Jan 21 2020, 6:09 PM

Not necessary anymore

ervin accepted this revision.Jan 22 2020, 7:22 AM
This revision is now accepted and ready to land.Jan 22 2020, 7:22 AM
Closed by commit R119:5a1d74059c09: KCM Notification port to ManagedConfigModule (authored by crossi). · Explain WhyJan 22 2020, 9:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 74081

View Options

kcms/notifications/kcm.h

Loading...
View Options

kcms/notifications/kcm.cpp

Loading...
View Options

kcms/notifications/package/contents/ui/PopupPositionPage.qml

Loading...
View Options

kcms/notifications/package/contents/ui/main.qml

Loading...