Differential D26044

Set breeze as default theme when reading from configuration file
ClosedPublic
Actions

Authored by bport on Dec 16 2019, 3:27 PM.

Details

Reviewers
ervin
crossi
ngraham
Group Reviewers
Plasma
Commits
R302:ed86f4f37c6b: Set breeze as default theme when reading from configuration file
Summary

Icons KCM is moved to KConfigXT, default value is "breeze" and in that case kdeglobals entry will be removed

Diff Detail

Repository
R302 KIconThemes
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bport created this revision.Dec 16 2019, 3:27 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 16 2019, 3:27 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bport requested review of this revision.Dec 16 2019, 3:27 PM
apol added a subscriber: apol.Dec 16 2019, 4:36 PM

LGTM otherwise

src/kiconloader.cpp
564

QStringLiteral

src/kicontheme.cpp
605

QStringLiteral

bport updated this revision to Diff 71955.Dec 21 2019, 3:30 PM

QString to QStringLiteral

bport marked 2 inline comments as done.Dec 21 2019, 3:31 PM
ngraham accepted this revision.Dec 21 2019, 4:19 PM
This revision is now accepted and ready to land.Dec 21 2019, 4:19 PM
ervin accepted this revision.Dec 23 2019, 11:11 AM
Closed by commit R302:ed86f4f37c6b: Set breeze as default theme when reading from configuration file (authored by bport). · Explain WhyDec 26 2019, 9:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kiconloader.cpp (3 lines)
Msrc/kicontheme.cpp (2 lines)

Diff 72193

View Options

src/kiconloader.cpp

Loading...
View Options

src/kicontheme.cpp

Loading...