Add advanced debugging to KIso

Authored by gengisdave on Aug 27 2016, 11:42 AM.



As in Krarc, we write the execution trace to a file. This is exactly the porting of KrDebugLogger made by @asensi (this means something can refer yet to krarc).

Test Plan

Builds fine, the file /tmp/kisodebug contains the same-style trace as in krdebug.

Diff Detail

R167 Krusader
Lint Skipped
Unit Tests Skipped
gengisdave updated this revision to Diff 6320.Aug 27 2016, 11:42 AM
gengisdave retitled this revision from to Add advanced debugging to KIso.
gengisdave updated this object.
gengisdave edited the test plan for this revision. (Show Details)
gengisdave added a reviewer: Krusader.
gengisdave set the repository for this revision to R167 Krusader.
gengisdave added a project: Krusader.
gengisdave added subscribers: Krusader, asensi.
martinkostolny accepted this revision.Aug 30 2016, 8:51 PM
martinkostolny added a reviewer: martinkostolny.
martinkostolny added a subscriber: martinkostolny.

Great, thanks!

This revision is now accepted and ready to land.Aug 30 2016, 8:51 PM

This patch can be applied on master; is this helpful, or the rework on VFS will make it obsolete?

abika added a subscriber: abika.Nov 20 2016, 4:35 PM

vfs_rework does not touch iso or krarc itself. But opening iso files with relative symlinks in path works just fine for me - in master and vfs_rework(!?).

However I cannot find a setting to browse iso files with the iso:// protocol by just a double-click. Only context-menu->"Browse Archive" works.

What distro do you have? I'll dive into KIO to see where the problem is.

abika added a comment.Nov 20 2016, 6:46 PM

What distro do you have? I'll dive into KIO to see where the problem is.

Arch, but I don't think this matters. It works in Dolphin but in Krusader double-clicking an ISO opens Ark.

Yes, kiso is missing the option we added to krarc (see!topic/krusader-devel/mN8uyxBj4Wg).

The solution is similar: in ListPanelFunc::openFileNameInternal we must add a method to check if the file could be opened with kiso.

aacid requested changes to this revision.Feb 26 2017, 10:40 PM
aacid added a subscriber: aacid.

Patch doesn't apply anymore

This revision now requires changes to proceed.Feb 26 2017, 10:40 PM