Differential D25949

KCM KWinDecoration port to KConfigXT
ClosedPublic
Actions

Authored by crossi on Dec 13 2019, 1:32 PM.

Details

Reviewers
ervin
bport
mart
davidedmundson
Group Reviewers
KWin
Commits
R108:687fcd820341: KCM KWinDecoration port to KConfigXT
Summary

Port to KConfigXt and also consider immutable element

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
crossi created this revision.Dec 13 2019, 1:32 PM
Restricted Application added a project: KWin. · View Herald TranscriptDec 13 2019, 1:32 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
crossi requested review of this revision.Dec 13 2019, 1:32 PM
davidedmundson added a comment.Dec 13 2019, 1:48 PM

Good stuff! Lots of red on a challenging KCM

kcmkwin/kwindecoration/kwindecorationsettings.kcfg
24

This looks wrong

crossi updated this revision to Diff 71442.Dec 13 2019, 2:01 PM

Fix wrong default value in kcfg

zzag added a subscriber: zzag.Dec 13 2019, 2:14 PM
zzag added inline comments.
kcmkwin/kwindecoration/kcm.h
50–53

KwinDecorationSettings

Naming nitpick: capitalize "win"

crossi updated this revision to Diff 71445.Dec 13 2019, 2:32 PM

proper naming (camel case)

ervin requested changes to this revision.Dec 23 2019, 9:56 AM

Just a small nitpick, otherwise looks fine to me.

kcmkwin/kwindecoration/package/contents/ui/Buttons.qml
240

I think it'd be worth splitting that up in several sub-expressions using properties just to improve readability.

This revision now requires changes to proceed.Dec 23 2019, 9:56 AM
crossi updated this revision to Diff 72887.Jan 6 2020, 1:32 PM

Break down nested ternary statement, add properies with explicit identifiers. Fix availableButtonsGrid.dragging property

ervin accepted this revision.Jan 6 2020, 1:57 PM

Looks good to me

This revision is now accepted and ready to land.Jan 6 2020, 1:57 PM
Closed by commit R108:687fcd820341: KCM KWinDecoration port to KConfigXT (authored by crossi). · Explain WhyJan 14 2020, 10:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 73500

View Options

kcmkwin/kwindecoration/CMakeLists.txt

Loading...
View Options

kcmkwin/kwindecoration/kcm.h

Loading...
View Options

kcmkwin/kwindecoration/kcm.cpp

Loading...
View Options

kcmkwin/kwindecoration/kwindecorationsettings.kcfg

Loading...
View Options

kcmkwin/kwindecoration/kwindecorationsettings.kcfgc

Loading...
View Options

kcmkwin/kwindecoration/package/contents/ui/Buttons.qml

Loading...
View Options

kcmkwin/kwindecoration/package/contents/ui/Themes.qml

Loading...
View Options

kcmkwin/kwindecoration/package/contents/ui/main.qml

Loading...
View Options

kcmkwin/kwindecoration/utils.h

Loading...
View Options

kcmkwin/kwindecoration/utils.cpp

Loading...