Port to KConfigXt and also consider immutable element
Details
Details
- Reviewers
ervin bport mart davidedmundson - Group Reviewers
KWin - Commits
- R108:687fcd820341: KCM KWinDecoration port to KConfigXT
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 20706 Build 20724: arc lint + arc unit
Comment Actions
Good stuff! Lots of red on a challenging KCM
kcmkwin/kwindecoration/kwindecorationsettings.kcfg | ||
---|---|---|
24 | This looks wrong |
kcmkwin/kwindecoration/kcm.h | ||
---|---|---|
50–53 |
Naming nitpick: capitalize "win" |
Comment Actions
Just a small nitpick, otherwise looks fine to me.
kcmkwin/kwindecoration/package/contents/ui/Buttons.qml | ||
---|---|---|
240 | I think it'd be worth splitting that up in several sub-expressions using properties just to improve readability. |
Comment Actions
Break down nested ternary statement, add properies with explicit identifiers. Fix availableButtonsGrid.dragging property