[platforms/drm] Fix cursor output rotation
AcceptedPublic

Authored by romangg on Dec 11 2019, 8:39 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Summary

The calculation of cursor position and orientation on outputs rotations other
than 0° and 180° was faulty.

This patch fixes both.

Test Plan

In live session cursor looks and moves as expected.

Diff Detail

Branch
cursor-rotation-fix
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 19761
Build 19779: arc lint + arc unit
romangg created this revision.Dec 11 2019, 8:39 PM
Restricted Application added a project: KWin. · View Herald TranscriptDec 11 2019, 8:39 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
romangg requested review of this revision.Dec 11 2019, 8:39 PM
zzag accepted this revision.Dec 11 2019, 9:38 PM
This revision is now accepted and ready to land.Dec 11 2019, 9:38 PM
apol added a subscriber: apol.Dec 11 2019, 10:17 PM

Just tested the patches with my test device. Works okay. +1 on the series, haven't looked at the code just yet.

A similar patch to this one will be necessary for touch since mouse works but touch is off.

In D25909#575918, @apol wrote:

Just tested the patches with my test device. Works okay. +1 on the series, haven't looked at the code just yet.

Thanks for testing.

A similar patch to this one will be necessary for touch since mouse works but touch is off.

See now D25921.

romangg updated this revision to Diff 71375.Dec 12 2019, 4:30 PM

Rebase on series changes.