Allows specifying the shell through an environment variable.
Allows forwarding command line arguments to kwin_wayland, since the arguments we
use on plasma phone are slightly different.
Details
Details
- Reviewers
bshah mart davidedmundson - Group Reviewers
Plasma - Commits
- R120:4bdbd44facf0: Make startplasma more flexible so it can be leveraged by plasma mobile
Builds, still starts
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| startkde/startplasma-wayland.cpp | ||
|---|---|---|
| 91 | having --xwayland always by default will unfortunately break my device port (xwayland crashes for me for some reason) | |
| startkde/startplasma-wayland.cpp | ||
|---|---|---|
| 91 | This is not changing, --xwayland is already on by default. In fact it will be possible to change the defaults by passing some arguments to startplasma-wayland. | |
| startkde/startplasma-wayland.cpp | ||
|---|---|---|
| 91 | Currently I can edit simple shell script (kwinwrapper) and remove the argument to kwin_wayland. If this is going to be hardcoded in the executable, it cannot be edited easily. I know I can work around (continue to use script). But despite the words "more flexible" in title, some flexibility in fact will be lost in the end (when using startplasma_wayland to start plasma-mobile session) | |
| startkde/startplasma-wayland.cpp | ||
|---|---|---|
| 91 | ||
| shell/main.cpp | ||
|---|---|---|
| 93 | I am bit unsure about this. We can simply write a configuration file in /etc/xdg using the plasma-phone-settings package. | |
| shell/main.cpp | ||
|---|---|---|
| 93 | On second thought, scratch all this. | |
| startkde/startplasma-wayland.cpp | ||
|---|---|---|
| 91 | Indeed, I overlooked, probably lack of { } around for loop confused me.. | |
| startkde/startplasma-wayland.cpp | ||
|---|---|---|
| 88 | Coding style, please. | |
| shell/main.cpp | ||
|---|---|---|
| 93 | For completion, this was already doable as is. | |