[renamedialog] Replace KIconLoader usage with QIcon::fromTheme
Needs ReviewPublic

Authored by nicolasfella on Tue, Dec 3, 12:45 AM.

Details

Reviewers
None
Group Reviewers
Frameworks
Test Plan

Triggered rename dialog. Still have icons in there

Diff Detail

Repository
R241 KIO
Branch
rena
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19453
Build 19471: arc lint + arc unit
nicolasfella created this revision.Tue, Dec 3, 12:45 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptTue, Dec 3, 12:45 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Tue, Dec 3, 12:45 AM

From what I understood loadMimeTypeIcon has this fallback to use "Unknown" icon, see D15451

  • Fall back to application-octet-stream

It's a bit ugly that fallback is a QIcon, not a QString :/
I will send a patch to Qt

Why is it ugly? I think the fallback is usually meant to fall back to e.g. a built-in icon pixmap, but doing a chain of fromTheme fallbacks is just fine imho.

Well, there are certainly more ugly things out there :)