Differential D25665

Port away from deprecated KBookmarksmenu API
ClosedPublic
Actions

Authored by nicolasfella on Dec 1 2019, 9:40 PM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Dolphin
Commits
R318:885916b7b486: Port away from deprecated KBookmarksmenu API
Summary

Needs to wait until we can depend on 5.65

See D25660 for context

Diff Detail

Repository
R318 Dolphin
Branch
bmm
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19356
Build 19374: arc lint + arc unit
nicolasfella created this revision.Dec 1 2019, 9:40 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptDec 1 2019, 9:40 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
nicolasfella requested review of this revision.Dec 1 2019, 9:40 PM
elvisangelaccio accepted this revision.Dec 8 2019, 12:53 PM
This revision is now accepted and ready to land.Dec 8 2019, 12:53 PM
nicolasfella added a comment.Mar 24 2020, 9:03 PM

@elvisangelaccio is it okay to depend on frameworks master or should I wait for the frameworks release before merging this?

elvisangelaccio added a comment.Mar 29 2020, 10:38 AM
In D25665#633867, @nicolasfella wrote:

@elvisangelaccio is it okay to depend on frameworks master or should I wait for the frameworks release before merging this?

It's okay, but I think you need to trigger the Dependency Build job on the CI in order to get a working dolphin build.

Closed by commit R318:885916b7b486: Port away from deprecated KBookmarksmenu API (authored by nicolasfella). · Explain WhyMar 30 2020, 1:49 PM
This revision was automatically updated to reflect the committed changes.
kossebau added a subscriber: kossebau.Mar 30 2020, 3:03 PM

Do not forget to bump set(KF5_MIN_VERSION "5.67.0"), as KBookmarkMenu docs say the API is only there since 5.59.

elvisangelaccio added a comment.Apr 5 2020, 6:17 PM
In D25665#638177, @kossebau wrote:

Do not forget to bump set(KF5_MIN_VERSION "5.67.0"), as KBookmarkMenu docs say the API is only there since 5.59.

Done with 924499a27933895b690036360c5e05f9e592fd79.

Revision Contents
Changeset List

PathPackages
Msrc/dolphinbookmarkhandler.cpp (7 lines)

Diff 70697

View Options

src/dolphinbookmarkhandler.cpp

Loading...