Port away from deprecated KBookmarksmenu API
ClosedPublic

Authored by nicolasfella on Dec 1 2019, 9:40 PM.

Details

Summary

Needs to wait until we can depend on 5.65

See D25660 for context

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Dec 1 2019, 9:40 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptDec 1 2019, 9:40 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
nicolasfella requested review of this revision.Dec 1 2019, 9:40 PM
elvisangelaccio accepted this revision.Dec 8 2019, 12:53 PM
This revision is now accepted and ready to land.Dec 8 2019, 12:53 PM

@elvisangelaccio is it okay to depend on frameworks master or should I wait for the frameworks release before merging this?

@elvisangelaccio is it okay to depend on frameworks master or should I wait for the frameworks release before merging this?

It's okay, but I think you need to trigger the Dependency Build job on the CI in order to get a working dolphin build.

This revision was automatically updated to reflect the committed changes.

Do not forget to bump set(KF5_MIN_VERSION "5.67.0"), as KBookmarkMenu docs say the API is only there since 5.59.

Do not forget to bump set(KF5_MIN_VERSION "5.67.0"), as KBookmarkMenu docs say the API is only there since 5.59.

Done with 924499a27933895b690036360c5e05f9e592fd79.