fix(kcm): improve i18n of device combobox
ClosedPublic

Authored by guoyunhe on Fri, Nov 22, 11:30 AM.

Details

Summary

The original label cause i18n problems, the parameter %1 is never given. The layout doesn't fit the form. This patch uses Kirigami label and form layout. And fix the i18n message.

Before:

After:

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
guoyunhe created this revision.Fri, Nov 22, 11:30 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Nov 22, 11:30 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
guoyunhe requested review of this revision.Fri, Nov 22, 11:30 AM
guoyunhe edited the summary of this revision. (Show Details)Fri, Nov 22, 11:31 AM
guoyunhe edited the summary of this revision. (Show Details)Fri, Nov 22, 11:34 AM

Before anything else you need to change the commit message (yes, just here, because reasons):
https://marc.info/?l=kde-devel&m=157350852208190&w=2

guoyunhe updated this revision to Diff 70151.Fri, Nov 22, 11:39 AM

update commit message

guoyunhe retitled this revision from Device ComboBox: fix label and layout to fix(kcm): fix label and layout of device combobox.Fri, Nov 22, 11:40 AM
romangg retitled this revision from fix(kcm): fix label and layout of device combobox to fix(kcm): improve i18n of device combobox.Fri, Nov 22, 2:52 PM
romangg added subscribers: broulik, romangg.

Thanks for the patch. @broulik: since you changed it last iirc is this good to go? Since it's a string change only master?

Should we reassign a reviewer?

Should we reassign a reviewer?

No, let me test it later today. But since it's a string change it can only go in master. If the translation team gives permission though it can also go in stable branch. You could try to get this permission in the meantime if you want it in the stable branch as well.

romangg requested changes to this revision.Fri, Dec 6, 8:16 PM

With this change controls are not aligned anymore in English language:

Did you test it?

This revision now requires changes to proceed.Fri, Dec 6, 8:16 PM
romangg accepted this revision.Fri, Dec 6, 8:21 PM

Ignore my previous comment. I thought it was aligned before. But it wasn't aligned there either.

This revision is now accepted and ready to land.Fri, Dec 6, 8:21 PM

It seems impossible to align them if they are not in one QML file. twinFormLayouts can only refer ids of current context. This happens in several different KCMs. Would be great to have a solution for global alignment. But I think that need some changes to Kirigami.

Closed by commit R104:3b10f0da5aa9: fix(kcm): improve i18n of device combobox (authored by Guo Yunhe <i@guoyunhe.me>). · Explain WhySat, Dec 7, 7:22 AM
This revision was automatically updated to reflect the committed changes.