The original label cause i18n problems, the parameter %1 is never given. The layout doesn't fit the form. This patch uses Kirigami label and form layout. And fix the i18n message.
Before:
After:
kde-i18n-doc | |
broulik | |
romangg |
Plasma | |
Localization |
The original label cause i18n problems, the parameter %1 is never given. The layout doesn't fit the form. This patch uses Kirigami label and form layout. And fix the i18n message.
Before:
After:
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Before anything else you need to change the commit message (yes, just here, because reasons):
https://marc.info/?l=kde-devel&m=157350852208190&w=2
Thanks for the patch. @broulik: since you changed it last iirc is this good to go? Since it's a string change only master?
No, let me test it later today. But since it's a string change it can only go in master. If the translation team gives permission though it can also go in stable branch. You could try to get this permission in the meantime if you want it in the stable branch as well.
With this change controls are not aligned anymore in English language:
Did you test it?
Ignore my previous comment. I thought it was aligned before. But it wasn't aligned there either.
It seems impossible to align them if they are not in one QML file. twinFormLayouts can only refer ids of current context. This happens in several different KCMs. Would be great to have a solution for global alignment. But I think that need some changes to Kirigami.