Differential D25255

fix(search): Allow to set empty type
ClosedPublic
Actions

Authored by iasensio on Nov 11 2019, 12:36 PM.

Details

Reviewers

elvisangelaccio

Group Reviewers

Dolphin

Commits

R318:adfc098aa747: fix(search): Allow to set empty type

Summary

This small patch allows to set and empty type to the extended options, which will set the Any Type option (index 0).
It doesn't make any change in current code, since this case is not called, but it helps simplifying follow-up patches.

Test Plan

No behavior changes with current code.
Calling setFacetsType(QString()) actually sets the first option (Any Type)

Diff Detail

Repository

R318 Dolphin

Branch

facets_empty_type

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18697
Build 18715: arc lint + arc unit

iasensio created this revision.Nov 11 2019, 12:36 PM

Restricted Application added a project: Dolphin. · View Herald TranscriptNov 11 2019, 12:36 PM

Restricted Application added a subscriber: kfm-devel. · View Herald Transcript

iasensio requested review of this revision.Nov 11 2019, 12:36 PM

Harbormaster completed remote builds in B18697: Diff 69582.Nov 11 2019, 12:36 PM

iasensio mentioned this in D25257: refactor(search): De-couple baloo URL parsing logic from UI.Nov 11 2019, 1:01 PM

iasensio added a dependency: D25257: refactor(search): De-couple baloo URL parsing logic from UI.Nov 11 2019, 1:14 PM

iasensio removed a dependency: D25257: refactor(search): De-couple baloo URL parsing logic from UI.Nov 11 2019, 1:39 PM

iasensio added a dependent revision: D25257: refactor(search): De-couple baloo URL parsing logic from UI.

iasensio mentioned this in D24422: [dolphin] Improve parsing of Baloo query searchString.Nov 13 2019, 12:02 AM

iasensio removed a dependent revision: D25257: refactor(search): De-couple baloo URL parsing logic from UI.Nov 13 2019, 1:22 AM

elvisangelaccio accepted this revision.Nov 13 2019, 8:48 PM

This revision is now accepted and ready to land.Nov 13 2019, 8:48 PM

Should I push this also to release/19.12?

Sure ;)

In D25255#562221, @elvisangelaccio wrote:

Sure ;)

To elaborate, in general we can push to the stable branch (release/19.12 currently) as long as we don't introduce new strings or new features and until the branch gets "frozen" for the final release tagging (5th december this time: https://community.kde.org/Schedules/Applications/19.12_Release_Schedule).

Big refactoring commits should still go to master though.

Closed by commit R318:adfc098aa747: fix(search): Allow to set empty type (authored by iasensio). · Explain WhyNov 13 2019, 9:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/search/dolphinfacetswidget.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	69582	b9a2df0		Nov 11 2019, 12:36 PM	★	★
Diff 2	69710	fc5546d	R318:adfc098aa74723ec3f01cda513290864ef9ee0f9	Nov 13 2019, 9:53 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
da1a62080dd7	89fa1679449e	b9a2df09fcb5	Ismael Asensio	fix(search): Allow to set empty type (Show More…)	Nov 9 2019, 2:58 AM

Diff 69582

View Options

src/search/dolphinfacetswidget.cpp