Right now, if you define topContent for your GlobalDrawer, it's added to the scrollview
so it can actually scroll out of sight, making it not always on top.
This patch moves the topContent above the scrollview so it always stays on top.
mart | |
apol | |
ahiemstra |
Kirigami |
Right now, if you define topContent for your GlobalDrawer, it's added to the scrollview
so it can actually scroll out of sight, making it not always on top.
This patch moves the topContent above the scrollview so it always stays on top.
Discover's GlobalDrawer toolbar no longer strangely scrolls out of view:
No regressions in Discover when the view is not scrollable
No regressions that I could detect in Kirigami Gallery, though this probably needs lots
more testing to ensure that nothing has exploded
BUG: 389533
FIXED-IN: 5.64
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
src/controls/GlobalDrawer.qml | ||
---|---|---|
241–244 | +1 for getting rid of these paddings. | |
252 | Uhm, what's this value? | |
260 | In my opinion, it is nicer to be explicit about types instead of relying on implicit conversion. So this should be (!root.collapsed || showTopContentWhenCollapsed) ? 1 : 0. | |
370 | We really should fix scrollview's scrollbars... |
src/controls/GlobalDrawer.qml | ||
---|---|---|
370 | See https://phabricator.kde.org/T9126. I *really* dislike overlay scrollbars, both in terms of utility and also because of the horrible code hacks required to make them work properly. Material for another patch though. |
I just reverted this, it causes all sort of breakages in the side drawers of many apps, mostly those that support the "collapsed sidebar" mode, like the emoji selector and ksysguardqml
Unfortunately, it has been pushed too near to framework release, so now it has been released, breaking several apps for a whole framework release.
big changes like that should go in only in like the first half of the month
src/controls/GlobalDrawer.qml | ||
---|---|---|
258 | General rule of thumb:
If you ever mix them you're asking for recursive loops. |
It has only been tagged so far, it's not been released yet.
The release will be next Saturday, maybe you should ask for a respin before that.
Done, I've asked @dfaure for a re-spin to pick up the reverting commit.
Sorry about this. :/ I'll try to fix it and re-submit for review for 5.65.