| mart | |
| bport | |
| davidedmundson |
| Plasma | |
| Frameworks |
This is a new type of ConfigModule which will manage the state of
"apply" and "defaults" by itself depending on the state of the KConfigXT
objects used within the module.
This is sligthly uncomplete on the "defaults" side due to missing
facilities in ConfigModule, but at least it shows the approach works.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Nice!
I'm not super sold on magically doing findChildren to get the config skeletons over an explicit
registerSettings(KCoreConfigSkeleton*).
I'm not against it either, but could you expand on the rationale.
| src/quickaddons/managedconfigmodule.cpp | ||
|---|---|---|
| 132 | Coding style {} is needed for single lines | |
| src/quickaddons/managedconfigmodule.h | ||
|---|---|---|
| 117 | I know this is just copy paste, but can you delete this paragraph as per https://phabricator.kde.org/D24824 | |
You mean here to sell it to you or in the doc or something else?
Indeed the alternative is registerSettings(), I went for the less explicit "children settings" mechanism mostly because it was closer to the older system around KCModule which was very much working by convention.
| src/quickaddons/managedconfigmodule.h | ||
|---|---|---|
| 211 | Right, makes sense for the future code. | |
Indeed the alternative is registerSettings(), I went for the less explicit "children settings" mechanism mostly because it was closer to the older system around KCModule which was very much working by convention.
Having similarity to the KCModule is a perfectly good reason. Ship it.