[KCM] Limit scale factor increment to 0.0625 on X11
Needs ReviewPublic

Authored by ngraham on Wed, Oct 2, 8:16 PM.

Details

Reviewers
romangg
Group Reviewers
Plasma
Summary

Because of the nature of floating point math and various Qt and X11 bugs, limiting the
scale factor increment to 0.0625 (6.25% in percentage form) will improve the display in
many apps.

For more information, see the discussions in https://bugreports.qt.io/browse/QTBUG-66036 and
the following bug reports:
CCBUG: 412447
CCBUG: 390451
CCBUG: 373232

Depends on D24370
Depends on D24371

Test Plan

Diff Detail

Repository
R104 KScreen
Branch
0625-increment-on-x11 (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17266
Build 17284: arc lint + arc unit
ngraham created this revision.Wed, Oct 2, 8:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Oct 2, 8:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Wed, Oct 2, 8:16 PM

I would just reformulate

"Scale factors are limited to multiples of 6.25% on X11 to minimize visual glitches in applications."

to

"Scale factors are limited to multiples of 6.25% to minimize visual glitches in applications."

I think adding X11 only makes this harder to understand for the users.

ngraham updated this revision to Diff 67226.Wed, Oct 2, 9:06 PM

Don't mention X11; it's too nerdy and technical