[KCM] Display scale factor as a percentage, not a decimal
AcceptedPublic

Authored by ngraham on Wed, Oct 2, 7:56 PM.

Details

Reviewers
romangg
ndavis
Group Reviewers
VDG
Plasma
Summary

This is the way GNOME and Windows present this information, and I think it's clearer
than using a decimal value.

The underlying value is still a float, we just convert to an int in percentage form for
display purposes.

Test Plan

Diff Detail

Repository
R104 KScreen
Branch
express-scale-factor-as-percentage (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17256
Build 17274: arc lint + arc unit
ngraham created this revision.Wed, Oct 2, 7:56 PM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Oct 2, 7:56 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Wed, Oct 2, 7:56 PM
ngraham retitled this revision from [KCM] Express scale factor as a percentage, not a decimal to [KCM] Display scale factor as a percentage, not a decimal.Wed, Oct 2, 7:57 PM
ngraham edited the summary of this revision. (Show Details)

+1. This is also in line with typical zoom factors in other applications such as Okular, which also use percent values.

ndavis accepted this revision.Thu, Oct 3, 6:00 AM
ndavis added a subscriber: ndavis.

+1. I find this a bit easier on the eyes.

This revision is now accepted and ready to land.Thu, Oct 3, 6:00 AM

@romangg, are you good with this?