[KCM] Display scale factor as a percentage, not a decimal
ClosedPublic

Authored by ngraham on Oct 2 2019, 7:56 PM.

Details

Summary

This is the way GNOME and Windows present this information, and I think it's clearer
than using a decimal value.

The underlying value is still a float, we just convert to an int in percentage form for
display purposes.

Test Plan

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Oct 2 2019, 7:56 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 2 2019, 7:56 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 2 2019, 7:56 PM
ngraham retitled this revision from [KCM] Express scale factor as a percentage, not a decimal to [KCM] Display scale factor as a percentage, not a decimal.Oct 2 2019, 7:57 PM
ngraham edited the summary of this revision. (Show Details)

+1. This is also in line with typical zoom factors in other applications such as Okular, which also use percent values.

ndavis accepted this revision.Oct 3 2019, 6:00 AM
ndavis added a subscriber: ndavis.

+1. I find this a bit easier on the eyes.

This revision is now accepted and ready to land.Oct 3 2019, 6:00 AM

@romangg, are you good with this?

romangg accepted this revision.Oct 16 2019, 2:30 PM
This revision was automatically updated to reflect the committed changes.