Can't we make KCrash just no-op on Android?

In D24025#533310, @broulik wrote:

Can't we make KCrash just no-op on Android?

It pretty much is. The problem I'm fixing only started to arise when I blacklisted it on the Android builds because it's 1) useless 2) brings in KWindowSytem as a dependency.

It pretty much boils down to the general question of whether we prefer having no-op/dummy stuff or explicitely exclude them on Android

Why not? it could be useful. The alternative is darkness over what happened there.

I surely don't want to have apps start to #ifdef a ton of stuff out, which works against the nature of Frameworks.

I think the line between dummy and #ifdef is in the commit message: if we don't want something on Android #ifdef is IMHO the way to go, if we merely don't have something yet, let's go for the dummy. A crash handler/bug reporter is something we certainly want I'd say, but something that currently isn't working yet.

In D24025#533418, @vkrause wrote:

I think the line between dummy and #ifdef is in the commit message: if we don't want something on Android #ifdef is IMHO the way to go, if we merely don't have something yet, let's go for the dummy. A crash handler/bug reporter is something we certainly want I'd say, but something that currently isn't working yet.

if we start ifdef'ing it out now, the day it works, we'll have to ifdef it back.
Also I don't really see why it shouldn't work at all now, is all the API missing? (haven't looked at it yet)

In D24025#533428, @apol wrote:

In D24025#533418, @vkrause wrote:

I think the line between dummy and #ifdef is in the commit message: if we don't want something on Android #ifdef is IMHO the way to go, if we merely don't have something yet, let's go for the dummy. A crash handler/bug reporter is something we certainly want I'd say, but something that currently isn't working yet.

if we start ifdef'ing it out now, the day it works, we'll have to ifdef it back.

That was exactly my point, let's not ifdef stuff we want eventually, like a crash handler, ifdef is for things that conceptually don't exist IMHO, like kauth/kdesu due to lack of a concept of elevated privileges. Sorry for confusing wording :)

Also I don't really see why it shouldn't work at all now, is all the API missing? (haven't looked at it yet)

AFAIK KCrash depends on gdb to produce useful results, no?