Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes
AcceptedPublic

Authored by meven on Tue, Sep 10, 8:22 PM.

Details

Reviewers
broulik
ngraham
Summary

D23650 added an empty trash check in trash fileRemoved triggering KDirNotify::emitFilesChanged.
Making the notification in emptytrashjob redundant and less prescise.
The two changes allow users to have reliable FilesChanged event when the trash is emptied whether by emptytrashjob or individual file deletion.

Needed for D23668

Diff Detail

Repository
R241 KIO
Branch
arcpatch-D23851
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16504
Build 16522: arc lint + arc unit
meven created this revision.Tue, Sep 10, 8:22 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptTue, Sep 10, 8:22 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Tue, Sep 10, 8:22 PM
meven retitled this revision from Avoid sending KDirNotify::emitFilesAdded when the trash is emptied to Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes.Tue, Sep 10, 8:51 PM
ngraham added a comment.EditedWed, Sep 11, 2:08 PM

If the only thing that EmptyTrashJob::slotFinished() does now is call SimpleJob::slotFinished(), do we even still need to override the base class's implementation of slotFinished()?

+1

If the on;y thing that EmptyTrashJob::slotFinished() does now is call SimpleJob::slotFinished(), do we even still need to override the base class's implementation of slotFinished()?

Yeah we don't, but we can't remove it because it would be a BIC.

ngraham accepted this revision.Fri, Sep 13, 10:07 PM

Ah, in that case just add a // TODO: remove this in KF6 comment.

This revision is now accepted and ready to land.Fri, Sep 13, 10:07 PM
meven updated this revision to Diff 66028.Sat, Sep 14, 9:30 AM

Add a KF6 clean up todo