Make UI look sharp in HiDPI display. Following this wiki https://techbase.kde.org/Development/Tutorials/Graphics/HiDPI
Before (@1.5):
After (@1.5):
KDE Applications |
Make UI look sharp in HiDPI display. Following this wiki https://techbase.kde.org/Development/Tutorials/Graphics/HiDPI
Before (@1.5):
After (@1.5):
No Linters Available |
No Unit Test Coverage |
Buildable 16335 | |
Build 16353: arc lint + arc unit |
Are you sure horizontalAdvance() is the correct thing here? boundingRect().width() seems more appropriate to me.
src/progressBox.cpp | ||
---|---|---|
92 | This increases the Qt dependency to 5.11, please change the CMakeLists.txt accordingly (or maybe try to use bondingRect and see if that works since that doesn't need a newer Qt than we need at tis point) |
According to Qt's source code, horizontalAdvance() is the exact replacement of width(), while boundingRect() is a different function. So I prefer to have horizontalAdvanced() if it doesn't cause any issues. https://github.com/qt/qtbase/commit/4d88d79aa507777bce40740b21747f656efc074d
Noticed that someone has changed width() to boundingRect() in master branch. I really hope someone can inform me to change the patch. Otherwise, we can never push it forward... Please review D23993