Differential D23655

Fixing bugs in new folders in tabs feature
ClosedPublic
Actions

Authored by feverfew on Sep 2 2019, 12:01 AM.

Details

Reviewers
elvisangelaccio
Commits
R318:a6403716439a: Fixing bugs in new folders in tabs feature
Summary

Fixing bug where urls in secondary view containers would not be considered
for the open new folders in tabs feature.

Test Plan

Manual testing. Testing for no regressions. Testing that URL is found if in secondary view container

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
feverfew created this revision.Sep 2 2019, 12:01 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptSep 2 2019, 12:01 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
feverfew requested review of this revision.Sep 2 2019, 12:01 AM
feverfew added a comment.EditedSep 2 2019, 12:04 AM

@ngraham I believe the diff in src/main.cpp may help with the speed issues in D11382. Haven't checked though...

@elvisangelaccio tagging for 19.08.1 is tomorrow. Would be nice if we got this in. Understand, if you're busy of course.

Also, I removed the toDisplayString stuff as I don't think we should be converting the '~' alias. However, should we still deal with trailing slashes?

feverfew updated this revision to Diff 65226.Sep 2 2019, 11:02 AM
  • Revert "Fixing bugs in new folders in tabs feature"
feverfew edited the summary of this revision. (Show Details)Sep 2 2019, 11:03 AM
feverfew edited the test plan for this revision. (Show Details)
feverfew edited the summary of this revision. (Show Details)
elvisangelaccio requested changes to this revision.Sep 2 2019, 8:00 PM
elvisangelaccio added inline comments.
src/dolphintabwidget.cpp
393–399

const

396–397

Please use DolphinTabPage::splitViewEnabled() (which makes the comment below redundant...)

Nitpick: else not necessary after return.

This revision now requires changes to proceed.Sep 2 2019, 8:00 PM
feverfew updated this revision to Diff 65274.Sep 2 2019, 8:29 PM

Simplifying getIndexByUrl function

feverfew marked an inline comment as done.Sep 2 2019, 8:30 PM
elvisangelaccio added inline comments.Sep 2 2019, 8:43 PM
src/dolphintabwidget.cpp
396–397

Please use DolphinTabPage::splitViewEnabled()

Still not fixed :P

elvisangelaccio accepted this revision.Sep 2 2019, 9:14 PM
elvisangelaccio added inline comments.
src/dolphintabwidget.cpp
396–397

Going to fix it myself before pushing.

This revision is now accepted and ready to land.Sep 2 2019, 9:14 PM
elvisangelaccio added inline comments.Sep 2 2019, 9:16 PM
src/dolphintabwidget.cpp
396–397

Ah sorry, I didn't see latest version of the patch ;)

Closed by commit R318:a6403716439a: Fixing bugs in new folders in tabs feature (authored by feverfew, committed by elvisangelaccio). · Explain WhySep 2 2019, 9:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 65276

View Options

src/dolphinmainwindow.cpp

Loading...
View Options

src/dolphintabwidget.h

Loading...
View Options

src/dolphintabwidget.cpp

Loading...