Differential D23655

Fixing bugs in new folders in tabs feature
ClosedPublic
Actions

Authored by feverfew on Sep 2 2019, 12:01 AM.

Details

Reviewers

elvisangelaccio

Commits

R318:a6403716439a: Fixing bugs in new folders in tabs feature

Summary

Fixing bug where urls in secondary view containers would not be considered
for the open new folders in tabs feature.

Test Plan

Manual testing. Testing for no regressions. Testing that URL is found if in secondary view container

Diff Detail

Repository

R318 Dolphin

Branch

splitViewImprov (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15972
Build 15990: arc lint + arc unit

feverfew created this revision.Sep 2 2019, 12:01 AM

Restricted Application added a project: Dolphin. · View Herald TranscriptSep 2 2019, 12:01 AM

Restricted Application added a subscriber: kfm-devel. · View Herald Transcript

feverfew requested review of this revision.Sep 2 2019, 12:01 AM

Harbormaster completed remote builds in B15972: Diff 65185.Sep 2 2019, 12:01 AM

@ngraham I believe the diff in src/main.cpp may help with the speed issues in D11382. Haven't checked though...

@elvisangelaccio tagging for 19.08.1 is tomorrow. Would be nice if we got this in. Understand, if you're busy of course.

Also, I removed the toDisplayString stuff as I don't think we should be converting the '~' alias. However, should we still deal with trailing slashes?

Revert "Fixing bugs in new folders in tabs feature"

Harbormaster completed remote builds in B16001: Diff 65226.Sep 2 2019, 11:03 AM

feverfew edited the summary of this revision. (Show Details)Sep 2 2019, 11:03 AM

feverfew edited the test plan for this revision. (Show Details)

feverfew edited the summary of this revision. (Show Details)

elvisangelaccio requested changes to this revision.Sep 2 2019, 8:00 PM

elvisangelaccio added inline comments.

src/dolphintabwidget.cpp
394–401	`const`
397–398	Please use `DolphinTabPage::splitViewEnabled()` (which makes the comment below redundant...) Nitpick: `else` not necessary after `return`.

This revision now requires changes to proceed.Sep 2 2019, 8:00 PM

Simplifying getIndexByUrl function

Harbormaster completed remote builds in B16026: Diff 65274.Sep 2 2019, 8:29 PM

feverfew marked an inline comment as done.Sep 2 2019, 8:30 PM

elvisangelaccio added inline comments.Sep 2 2019, 8:43 PM

src/dolphintabwidget.cpp
397–398	Please use DolphinTabPage::splitViewEnabled() Still not fixed :P

elvisangelaccio accepted this revision.Sep 2 2019, 9:14 PM

elvisangelaccio added inline comments.

src/dolphintabwidget.cpp
397–398	Going to fix it myself before pushing.

This revision is now accepted and ready to land.Sep 2 2019, 9:14 PM

elvisangelaccio added inline comments.Sep 2 2019, 9:16 PM

src/dolphintabwidget.cpp
397–398	Ah sorry, I didn't see latest version of the patch ;)

Closed by commit R318:a6403716439a: Fixing bugs in new folders in tabs feature (authored by feverfew, committed by elvisangelaccio). · Explain WhySep 2 2019, 9:18 PM

This revision was automatically updated to reflect the committed changes.

elvisangelaccio mentioned this in D23860: DolphinTabWidget: cleanup index-by-URL API usage.Sep 10 2019, 11:15 PM

elvisangelaccio mentioned this in R318:ef5732c89bc5: DolphinTabWidget: cleanup index-by-URL API usage.Sep 14 2019, 12:15 PM

Revision Contents
Changeset List

			Path	Packages
M			src/dolphinmainwindow.cpp (2 lines)
M			src/dolphintabwidget.h (8 lines)
M			src/dolphintabwidget.cpp (30 lines)
M			src/main.cpp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	65185	9cd042a		Sep 2 2019, 12:01 AM	★	★
Diff 2	65226	9cd042a	- Revert "Fixing bugs in new folders in tabs feature"	Sep 2 2019, 11:02 AM	★	★
Diff 3	65274	9cd042a	Simplifying getIndexByUrl function	Sep 2 2019, 8:29 PM	★	★
Diff 4	65276	56b3059	R318:a6403716439ae72bfdf86a14af94ea9d212f08ee	Sep 2 2019, 9:15 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
734c51cc822d	c874237ebf85	d5befb383e91	Alexander Saoutkin	Defer DBus service creation until all DBus objects have been created.	Sep 1 2019, 11:56 PM
d5befb383e91	3f7aa32ce5cf	9cd042a86c85	Alexander Saoutkin	Fixing bug where urls in secondary view containers would not be considered for… (Show More…)	Sep 1 2019, 11:53 PM