DolphinTabWidget: cleanup index-by-URL API usage
ClosedPublic

Authored by elvisangelaccio on Tue, Sep 10, 11:15 PM.

Details

Summary

Follow-up of D23655 where we didn't have time to polish the code:

  • add a couple of variables to make the code more clear.
  • remove the get prefix which we usually don't use in Qt code.
  • make the function private since it's very tied to implementation.
  • add a new isUrlOpen public method as wrapper.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Dolphin. · View Herald TranscriptTue, Sep 10, 11:15 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
elvisangelaccio requested review of this revision.Tue, Sep 10, 11:15 PM
feverfew accepted this revision.Wed, Sep 11, 7:30 AM

Assuming it's tested LGTM.

This revision is now accepted and ready to land.Wed, Sep 11, 7:30 AM
This revision was automatically updated to reflect the committed changes.