Promote KCM to top level and rename accordingly
ClosedPublic

Authored by ngraham on Wed, Aug 28, 4:59 PM.

Details

Summary

Now that the Phonon KCM has been removed, there's no longer a need to put the plasma-pa
KCM inside the Multimedia category, since that category now only includes one item.

This patch promotes the KCM to be visible on the top-level in the Hardware category, and
tweaks its name and tooltip text to reflect how it now manages all audio devices.

Test Plan

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Branch
promote-audio-kcm (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15762
Build 15780: arc lint + arc unit
ngraham created this revision.Wed, Aug 28, 4:59 PM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Aug 28, 4:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Wed, Aug 28, 4:59 PM

+1 in general.

Please note that k3b ships the 'CDDB retrieval' KCM, which is in the Multimedia section as well

nicolasfella added inline comments.Wed, Aug 28, 5:09 PM
src/kcm/kcm_pulseaudio.desktop
14

Is there a (significant) difference between Audio and Sound? Otherwise I'd go with just 'Audio'

Hmm, maybe that one should go to the top level too.

ngraham updated this revision to Diff 64871.Wed, Aug 28, 5:16 PM

Be less redundant

ngraham edited the test plan for this revision. (Show Details)Wed, Aug 28, 5:16 PM
ngraham marked an inline comment as done.
nicolasfella accepted this revision.Wed, Aug 28, 5:22 PM
This revision is now accepted and ready to land.Wed, Aug 28, 5:22 PM
ndavis added a subscriber: ndavis.Wed, Aug 28, 7:01 PM

+1

src/kcm/module.cpp
39

Why are we changing the title to just "Audio"? Weren't we supposed to use descriptions for the page titles to make them useful? Am I mistaken?

ngraham added inline comments.Wed, Aug 28, 7:18 PM
src/kcm/module.cpp
39

Our conclusion before was to make the page title match the title listed in the desktop file, and the comment has a description. You can see this in all the KCMs in the Appearance section This seems semantically correct, and if we want to display the descriptive string, we should change KPageDialog or something in KCMUtils to parse the comment in the desktop file and display it underneath the title. Frankly that should happen anyway so we don't have to define the same string for the title in both the desktop file and also the kaboutdata.

ngraham marked 2 inline comments as done.Sun, Sep 1, 3:06 AM
ngraham closed this revision.Sun, Sep 1, 3:19 AM

Can you still re-order devices to set priority of input/output devices?

Can you still re-order devices to set priority of input/output devices?

That's not relevant to this patch, which only moves the KCM to the top level. No functionality has been lost; if you require advanced settings like setting device priorities, you can still do it via the phononsettings tool.

Can you still re-order devices to set priority of input/output devices?

That's not relevant to this patch, which only moves the KCM to the top level. No functionality has been lost; if you require advanced settings like setting device priorities, you can still do it via the phononsettings tool.

But moving KCM to the top level removes Multimedia section (at least that's what is visible on a screenshot) which was used to access priority (I assume that's phononsettings), hence my question, e.g. this will not be easily accessible via GUI if I understand correctly?

That's correct. I guess this can be considered an advanced feature.

wbauer added a subscriber: wbauer.Wed, Sep 4, 5:49 AM

Please note that k3b ships the 'CDDB retrieval' KCM, which is in the Multimedia section as well

That's actually part of libkcddb and not k3b, btw.

And there's also audiocd-kio's "Audio CDs" KCM in Multimedia too.

Since the only things that can appear in Multimedia now are CD related, maybe we should rename it?