[KUrlNavigator] Add MIME types supported by krarc to isCompressedPath
ClosedPublic

Authored by nhiga on Aug 27 2019, 1:11 PM.

Details

Summary

With D23476 applied, this patch should let users who have Krusader installed to view files inside a 7z or RAR archive in KDE applications (such as Gwenview) without decompressing the whole archive to another location. They will also be able to navigate the archive using Dolphin.

BUG: 386448
FIXED-IN: 5.62

Test Plan

Test using Dolphin:
Enable "Open archives as folder" in Dolphin, then open a 7z/RAR archive. It should be using the krarc protocol. Then browse the archive. Click on the breadcrumb in the location area for a parent folder which is outside the archive to make sure Bug 386448 does not occur.

Test using Gwenview:
View a 7z/RAR archive containing photos. Browse and view images inside the archive.

Diff Detail

Repository
R241 KIO
Lint
Lint Skipped
Unit
Unit Tests Skipped
nhiga requested review of this revision.Aug 27 2019, 1:11 PM
nhiga created this revision.
nhiga added a comment.Aug 27 2019, 1:14 PM

This patch may be related to Bug 411330.

ngraham edited the summary of this revision. (Show Details)Aug 27 2019, 3:24 PM
ngraham edited reviewers, added: Frameworks, cfeck, pino, dfaure; removed: kde-frameworks-devel.
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald TranscriptAug 27 2019, 3:24 PM

What happens if krarc isn't installed? We try and fail and move on silently as if nothing happened, so this patch is indeed harmless? I see it's your test plan, but I want to be sure of what actually happens.

nhiga edited the summary of this revision. (Show Details)Aug 28 2019, 11:49 AM
nhiga edited the test plan for this revision. (Show Details)

When this patch is applied and Krusader is not installed:

Dolphin (with "Open archives as folder" enabled): Opens the 7z/RAR archive using Ark.
Gwenview: 7z/RAR archives will not appear (probably because it is unsupported without krarc).

dfaure accepted this revision.Aug 30 2019, 4:21 PM
This revision is now accepted and ready to land.Aug 30 2019, 4:21 PM
This revision was automatically updated to reflect the committed changes.