Add support for handling QNAM SSL errors to KSslErrorUiData
ClosedPublic

Authored by vkrause on Wed, Aug 21, 5:01 PM.

Details

Summary

This allows the use of KIO's SSL error UI and its session/persistent overrides also for SSL errors encountered via QNAM, besides KIO, KTcpSocket and QSslSocket.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Wed, Aug 21, 5:01 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptWed, Aug 21, 5:01 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Wed, Aug 21, 5:01 PM
apol added a subscriber: apol.Thu, Aug 22, 12:40 AM

Makes sense, but I feel some explanation is missing ^^'

Put it in the commit message?

vkrause edited the summary of this revision. (Show Details)Thu, Aug 22, 6:43 AM
In D23323#516317, @apol wrote:

Makes sense, but I feel some explanation is missing ^^'

Put it in the commit message?

Better: put it into the API documentation?

In D23323#516317, @apol wrote:

Makes sense, but I feel some explanation is missing ^^'

Put it in the commit message?

Better: put it into the API documentation?

It's in the class documentation already, although that can be improved to not solely refer to KTcpSocket anymore (which is already wrong now).

dfaure accepted this revision.Sat, Aug 31, 5:04 PM
dfaure added inline comments.
src/core/ktcpsocket.h
416

@since 5.62

This revision is now accepted and ready to land.Sat, Aug 31, 5:04 PM
This revision was automatically updated to reflect the committed changes.