Differential D23323

Add support for handling QNAM SSL errors to KSslErrorUiData
ClosedPublic
Actions

Authored by vkrause on Aug 21 2019, 5:01 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:b97ce61950c9: Add support for handling QNAM SSL errors to KSslErrorUiData
Summary

This allows the use of KIO's SSL error UI and its session/persistent overrides also for SSL errors encountered via QNAM, besides KIO, KTcpSocket and QSslSocket.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Aug 21 2019, 5:01 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 21 2019, 5:01 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Aug 21 2019, 5:01 PM
apol added a subscriber: apol.Aug 22 2019, 12:40 AM

Makes sense, but I feel some explanation is missing ^^'

Put it in the commit message?

vkrause edited the summary of this revision. (Show Details)Aug 22 2019, 6:43 AM
dhaumann added a subscriber: dhaumann.Aug 25 2019, 7:02 PM
In D23323#516317, @apol wrote:

Makes sense, but I feel some explanation is missing ^^'

Put it in the commit message?

Better: put it into the API documentation?

vkrause added a comment.Aug 26 2019, 8:45 AM
In D23323#519093, @dhaumann wrote:
In D23323#516317, @apol wrote:

Makes sense, but I feel some explanation is missing ^^'

Put it in the commit message?

Better: put it into the API documentation?

It's in the class documentation already, although that can be improved to not solely refer to KTcpSocket anymore (which is already wrong now).

dfaure accepted this revision.Aug 31 2019, 5:04 PM
dfaure added inline comments.
src/core/ktcpsocket.h
416

@since 5.62

This revision is now accepted and ready to land.Aug 31 2019, 5:04 PM
Closed by commit R241:b97ce61950c9: Add support for handling QNAM SSL errors to KSslErrorUiData (authored by vkrause). · Explain WhyAug 31 2019, 6:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/ktcpsocket.h (8 lines)
Msrc/core/ktcpsocket.cpp (19 lines)

Diff 65061

View Options

src/core/ktcpsocket.h

Loading...
View Options

src/core/ktcpsocket.cpp

Loading...