Could we only apply the :xx check on the filename part, not on the server part? Someone might expect that http://path.to/file.txt:99 also works for remote files.

In D22525#497332, @cfeck wrote:

Could we only apply the :xx check on the filename part, not on the server part? Someone might expect that http://path.to/file.txt:99 also works for remote files.

I don't think that rewriting http://path.to/file.txt:99 to http://path.to/file.txt?line=99 is a good idea. I'd better not touch non`file://` URLs at all.

Oh, if the latter syntax also works, then you are right.

In D22525#497556, @cfeck wrote:

Oh, if the latter syntax also works, then you are right.

Not sure what you mean by "also works". Current code checks if the URL ends with :x:y and turns it into ?line=x&column=y. This is used to open local text files at the given cursor position. However, for URL's like http://localhost:3000 it is invalid to perform such transformation. My patch checks URL scheme and applies the transformation only if it is file://.

In D22525#498393, @dfaure wrote:

I suppose the kate developers like the fact that this currently works over FTP, SFTP, FISH, SMB, etc.
So maybe only HTTP[S]/WEBDAV should be blacklisted (because there queries have a different meaning, one that we can't know client-side).

I'm confused. I just tried SFTP and SMB without the patch and it also doesn't work. As I said, it is invalid to rewrite URLs for remote schemas.

What about the stable 5.16 branch?
It has only be committed to master so far AFAICS, so the fix would only end up in Plasma 5.17 which is still 3 months away...

I'm not familiar with KDE release engineering, so I'm asking to do merging someone else.

Backported. https://commits.kde.org/kde-cli-tools/42ef318a9d1c454f96b60181d8231a59233720ea

Thanks!