Add global shortcuts for switching to the previous/next activity
ClosedPublic

Authored by muesli on Jul 10 2019, 3:57 PM.

Details

Summary

We currently have a mouse-wheel action to switch to the previous/next activity,
but it wasn't possible to assign a global keyboard shortcut to these actions.

As discussed on Phabricator, this doesn't define a default key-sequence yet,
but at least gives users the possibility to assign there own ones, which wasn't
possible before.

Diff Detail

Repository
R120 Plasma Workspace
Branch
shortcut-prevnext-activity (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21016
Build 21034: arc lint + arc unit
muesli created this revision.Jul 10 2019, 3:57 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 10 2019, 3:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
muesli requested review of this revision.Jul 10 2019, 3:57 PM
ivan added a subscriber: ivan.Oct 3 2019, 5:44 PM

I'm not thrilled about having default shortcuts set. We have the shortcuts space quite polluted as it is.

Especially since we have the meta+tab with different semantics.

Maybe the text should explicitly state what 'next' means in this case.

muesli added a comment.Oct 3 2019, 5:51 PM
In D22382#541626, @ivan wrote:

I'm not thrilled about having default shortcuts set. We have the shortcuts space quite polluted as it is.

I'm happy to remove the defaults (even though I consider them fairly consistent with our other defaults), but at least users can still define their own global shortcuts then.

Maybe the text should explicitly state what 'next' means in this case.

Like: "switch to next activity (in alphabetical order)"?

ngraham added subscribers: romangg, ngraham.

I agree that we should set some global shortcut (otherwise there's practically no point; only 0.001% of users ever set custom global shortcuts). No opinions regarding this one though. Adding more folks for comment.

Would love to finish this one up! :)
Any suggestions how to move forward?

The Meta+Ctrl+Left/Light shortcuts being proposed for virtual desktop switching in D24281. Let's wait to see what shakes out of that first.

muesli added a comment.EditedJan 11 2020, 6:21 PM

While waiting for that separate discussion and decision, does anyone mind if I land this _without_ default shortcuts set?

At least it enables people to switch to the previous/next activity when they configure a shortcut manually. Currently that's not possible, as one can only define shortcuts for specific activities.

We can still argue and discuss what an appropriate default should be at a later point.

That seems reasonable to me as a path forward.

muesli updated this revision to Diff 73354.Jan 12 2020, 8:51 PM
  • Remove default key-sequence for "Previous/Next Activity" shortcut

Oops, I'm not sure what I've did here was what I intended: I rebased master (>800 commits since my original changeset) into my feature branch because I otherwise couldn't build/test my changes anymore, but obviously I didn't touch/change > 600 files.
Is this how phabricator is supposed to look in such a scenario, or how should I have resolved this scenario?

Gross, I hate it when Phabricator does that. :( I still haven't figured out what causes this. Whenever it happens, I just go back in the history (in this case https://phabricator.kde.org/D22382?vs=on&id=61521&whitespace=ignore-most#toc) copy the diff, manually apply it to HEAD and force-update the revision with arc diff --update D22382.

If that doesn't work then I use the Update Diff action in the web interface to manually replace the current diff with a real one.

Sorry about this nonsense. :/

muesli updated this revision to Diff 73412.Jan 13 2020, 2:27 PM

Hopefully fix phabricator getting out of sync with the changeset.

muesli edited the summary of this revision. (Show Details)Jan 13 2020, 2:28 PM
muesli edited the summary of this revision. (Show Details)

Alright, I think this looks sane again. @ngraham Mind if I land this in its current state?

davidedmundson accepted this revision.Jan 13 2020, 2:47 PM
This revision is now accepted and ready to land.Jan 13 2020, 2:47 PM
ngraham accepted this revision.Jan 13 2020, 3:05 PM

I think so!

This revision was automatically updated to reflect the committed changes.