Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"
ClosedPublic

Authored by ndavis on Jul 9 2019, 10:03 PM.

Details

Summary

This reverts the following commits:
fff556af1939d17453540f4388b27650359258dd
5de082c39b91f804fa6d50bfa9df9f7463d286dd
33be0f5b8b877a8a3bf99752ababf38b54d9145d

I think I did this change the wrong way. What we really need is a way to use different sizes for different panel widgets by default without making it impossible for users to configure the size.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Jul 9 2019, 10:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 9 2019, 10:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ndavis requested review of this revision.Jul 9 2019, 10:03 PM
filipf added a subscriber: filipf.Jul 29 2019, 10:53 PM

I don't feel too wise regarding this, pinging Plasma in case someone has advice.

Can you give a bit more rationale?

Can you give a bit more rationale?

Some users complained about the buttons being smaller or the size not being configurable when it previously was.

davidedmundson accepted this revision.Jul 31 2019, 5:31 PM

Some users complained about the buttons being smaller or the size not being configurable when it previously was.

Whatever you change some users will always complain.
It's important not to knee-jerk react based on some comments if they go against the general trend.

Code-wise it's no worse than before your patches, so I'm happy to accept, but if you want to keep it as-is, I would support that too.

Your call.

This revision is now accepted and ready to land.Jul 31 2019, 5:31 PM

I was hesitant about making this change before I committed it, so it's not a knee jerk reaction, but I also don't think it's important for me to land this quickly. I might want to see if I can come up with the real solution.

Seems like people still complain about the patch, so I'll go ahead and land this.

This revision was automatically updated to reflect the committed changes.