[System Tray] Unified data model for System Tray items
Needs ReviewPublic

Authored by kmaterka on Aug 24 2019, 10:32 PM.


Group Reviewers

Currently there are two different sources of SystemTray items:

  • Plasmoids
  • Status Notifier

Both are implemented independently, which makes hard to implement features that should cover both types.

This is a first step in bigger rework that should allow easy ordering, filtering etc.

Test Plan

Almost all features can be affected, so everything needs to be tested.

Diff Detail

R120 Plasma Workspace
Lint Skipped
Unit Tests Skipped
kmaterka created this revision.Aug 24 2019, 10:32 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 24 2019, 10:32 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kmaterka requested review of this revision.Aug 24 2019, 10:32 PM

I spent some time testing it and I hope it is now bug free. I understand it is a big change that brings little value (now), but I'm working on further improvements and wanted to slip work into smaller patches.

ngraham edited reviewers, added: broulik; removed: Plasma: Workspaces.Aug 24 2019, 10:43 PM
kmaterka updated this revision to Diff 64669.Aug 26 2019, 2:26 PM

Now the same model is used for:

  • rendering all items, both Plasmoids and StatusNotifications
  • "Entries" configuration page

That should greatly simplify the https://phabricator.kde.org/D22176 (this is not my patch). It will also fix issue I mentioned in that review.

Seems to work fine for me, but someone else should comment on the code