[System Tray] Unified data model for System Tray items
AbandonedPublic

Authored by kmaterka on Aug 24 2019, 10:32 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Summary

Currently there are two different sources of SystemTray items:

  • Plasmoids
  • Status Notifier

Both are implemented independently, which makes hard to implement features that should cover both types.

This is a first step in bigger rework that should allow easy ordering, filtering etc.

Test Plan

Almost all features can be affected, so everything needs to be tested.

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18842
Build 18860: arc lint + arc unit
kmaterka created this revision.Aug 24 2019, 10:32 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 24 2019, 10:32 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kmaterka requested review of this revision.Aug 24 2019, 10:32 PM

I spent some time testing it and I hope it is now bug free. I understand it is a big change that brings little value (now), but I'm working on further improvements and wanted to slip work into smaller patches.

ngraham edited reviewers, added: broulik; removed: Plasma: Workspaces.Aug 24 2019, 10:43 PM
kmaterka updated this revision to Diff 64669.Aug 26 2019, 2:26 PM

Now the same model is used for:

  • rendering all items, both Plasmoids and StatusNotifications
  • "Entries" configuration page

That should greatly simplify the https://phabricator.kde.org/D22176 (this is not my patch). It will also fix issue I mentioned in that review.

Seems to work fine for me, but someone else should comment on the code

kmaterka updated this revision to Diff 69821.Nov 15 2019, 7:14 PM
kmaterka edited the test plan for this revision. (Show Details)

Rebased, but I need to test it

kmaterka updated this revision to Diff 69823.Nov 15 2019, 8:56 PM

Fixed one mistake during rebase. I checked it, seems it is still working.

anthonyfieroni added inline comments.
applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
61–83

Remove that code as well.

kmaterka marked an inline comment as done.Nov 16 2019, 10:16 AM
kmaterka added inline comments.
applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
61–83

Done

kmaterka updated this revision to Diff 69832.Nov 16 2019, 10:17 AM
kmaterka marked an inline comment as done.

Small code review change

kmaterka abandoned this revision.Nov 28 2019, 4:46 PM

Smaller subset of changes (model only for configuration page) extracted to D25580, needed for the D22176. If D25580 gets accepted, I will create separate revision for rest of the changes.